Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split ChildrenChanged/TextChanged events into distinct Inserted/Deleted events #194

Closed
wants to merge 5 commits into from
Closed

Split ChildrenChanged/TextChanged events into distinct Inserted/Deleted events #194

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6afeda0
Split TextChangedEvent into TextInserted/TextDeleted
TTWNO Jun 20, 2024
87178bc
Split ChildrenChangedEvent into ChildrenInserted/ChildrenDeleted
TTWNO Jun 20, 2024
a46e665
Fix docs
TTWNO Jun 20, 2024
a529f43
s/Removed/Deleted/g
TTWNO Jun 20, 2024
c87f82d
Update type names in benchmark suite
TTWNO Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions atspi-common/src/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,9 @@
/// On specific types, if the event / message member does not match the Event's name.
InterfaceMatch(String),

/// On specific types, if the event / kind discriminant does not match the Event's discriminant.
KindMismatch(String),

/// To indicate a match or equality test on a signal body signature failed.
UnknownBusSignature(String),

Expand Down Expand Up @@ -79,6 +82,9 @@
Self::InterfaceMatch(e) => {
f.write_str(format!("atspi: interface mismatch in conversion: {e}").as_str())
}
Self::KindMismatch(e) => {
f.write_str(format!("atspi: kind mismatch in conversion: {e}").as_str())

Check warning on line 86 in atspi-common/src/error.rs

View check run for this annotation

Codecov / codecov/patch

atspi-common/src/error.rs#L85-L86 

Added lines #L85 - L86 were not covered by tests
}
Self::UnknownBusSignature(e) => {
f.write_str(format!("atspi: Unknown bus body signature: {e:?}").as_str())
}
Expand Down
2 changes: 1 addition & 1 deletion atspi-common/src/events/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -940,7 +940,7 @@ assert_obj_safe!(EventProperties);
/// For a similar, but object-safe trait, see [`EventProperties`].
pub trait BusProperties {
/// The `DBus` member for the event.
/// For example, for an [`object::TextChangedEvent`] this should be `"TextChanged"`
/// For example, for an [`object::TextInsertedEvent`] this should be `"TextChanged"`
const DBUS_MEMBER: &'static str;
/// The `DBus` interface name for this event.
/// For example, for any event within [`object`], this should be "org.a11y.atspi.Event.Object".
Expand Down
Loading
Loading