-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'bus-tree' example #188
Conversation
Prevents rust-analyzer from making noise over missing features using the static `assert_cfg!` in the bus_tree example. We may want to use the `static_cfg!` in other examples too.
"futures" because "futures-lite" does not provide `join_all!'. "static_assertions" to help users use examples. "display-tree" for tree printing in the 'bus-tree' example. Also sorted the dev-dependencies.
Adds the 'bus-tree' example. Addresses issue #173
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #188 +/- ##
==========================================
- Coverage 86.69% 86.54% -0.16%
==========================================
Files 39 39
Lines 3337 3344 +7
==========================================
+ Hits 2893 2894 +1
- Misses 444 450 +6 ☔ View full report in Codecov by Sentry. |
Add `[[example]]` binary sections and add required-features lists on them. Also clean up examples from old ways. Also removes .vscode to suppress clippy-grunts. Also remove static-assertions from dev-dependencies in atspi crate.
Sometimes borrowing may be impractical. This adds the owning conversion.
…_proxy` The implementation we had tried to avoid cloning, but did so anyway under the hood. Better to do so explicitly and simplify the implementations.
Pull in changes I made locally to simplify and extend `ObjectRefExt`.
With the new iterative method the example's MSRV should now be Rust 1.75 As a bonus, this implementation is much faster with common-sized trees.
@luukvanderduim is it possible, knowing what we know able Libreoffice Calc (2^31 children-cells), could you please add functionality for modelling "countable but almost infinite children"? |
Yeah.. it comes at the cost of adding a call per child to get the number of children. A reasonable number:
A legal threshold:
Or without the extra call. This will cover all stalling responses not just for (in practical terms) infinite children.
|
…example Synchronize with latest changes on 'main'.
This seems good to me. |
We know some applications may expose huge child counts, which will stall the program. This imposes an upper limit of 2^16 chilren. If an object says to have more children, the example will skip it.
Last commit confirmed to make the example resilient against an 'infinite' number of children. |
Addresses issue #173
Also try outstatic_assertions::assert_cfg!
to inform users of the appropriate features to use.This will make rust-analyzer noisy if you don't have these set in your editor.
[[example]]
section in Cargo.toml, which allows us to point out, using therequired-features
list which features a user needs.This tries to add.vscode/settings.json
to mitigate that but if this is deemed too opinionated, just remove it.removed, no longer needed.