Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stricten type of ObjectRef::name #186

Merged
merged 6 commits into from
May 24, 2024
Merged

Stricten type of ObjectRef::name #186

merged 6 commits into from
May 24, 2024

Conversation

TTWNO
Copy link
Member

@TTWNO TTWNO commented May 22, 2024

  • Accoring to DBus specification, there is always a UniqueName style bus name.1

@DataTriny
Copy link
Collaborator

What's the purpose of the file atspi-common/p1.txt you've included as part of this PR?

Copy link

codecov bot commented May 22, 2024

Codecov Report

Attention: Patch coverage is 90.47619% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.69%. Comparing base (280f3b2) to head (6d2b6e1).

Files Patch % Lines
atspi-proxies/src/accessible.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #186      +/-   ##
==========================================
- Coverage   86.69%   86.69%   -0.01%     
==========================================
  Files          39       39              
  Lines        3338     3337       -1     
==========================================
- Hits         2894     2893       -1     
  Misses        444      444              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TTWNO
Copy link
Member Author

TTWNO commented May 22, 2024

What's the purpose of the file atspi-common/p1.txt you've included as part of this PR?

Whoopsie; was some old testing data that didn't get cleared.

@TTWNO TTWNO marked this pull request as ready for review May 22, 2024 20:43
@TTWNO TTWNO requested a review from luukvanderduim May 23, 2024 18:50
@TTWNO TTWNO merged commit 10caea7 into main May 24, 2024
13 checks passed
@TTWNO TTWNO deleted the bus-name-to-uniqe-name branch May 24, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants