CI: Run nightly Clippy instead of stable and beta. #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run less, cover more, more up-to-date `main`. Newer clippy versions have the previous' versions lints plus some more. No matter which toolchain you run, `main` will be up to date with all lints until new lintes are added. Downside: The added nightly lints may contain bugs. This is true but so do stable. Either the: - errors are not found by the lint in which case we will only learn of the error when the bug gets fixed. - errors are false positives. These patterns are usually quickly found and fixed overnight.
|
Wonderful idea! Let's merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Run less, cover more, more up-to-date
main.Newer clippy versions have the previous' versions lints plus some more. No matter which toolchain you run,
mainwill be up to date with all lints until new lintes are added.Downside:
The added nightly lints may contain bugs.
This is true but so do stable.
Either the:
If we are bothered by a particular crate we can always
#[allow(clippy::bothersome-lint-in-our-context)]