Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release Version 1.0.9 #71

Merged
merged 10 commits into from
May 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 30 additions & 0 deletions .github/workflows/moodle-ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -85,6 +85,36 @@ jobs:
- php: '8.1'
moodle-branch: 'MOODLE_403_STABLE'
database: mariadb
- php: '8.1'
moodle-branch: 'MOODLE_404_STABLE'
database: pgsql
- php: '8.1'
moodle-branch: 'MOODLE_404_STABLE'
database: mariadb
- php: '8.2'
moodle-branch: 'MOODLE_402_STABLE'
database: pgsql
- php: '8.2'
moodle-branch: 'MOODLE_402_STABLE'
database: mariadb
- php: '8.2'
moodle-branch: 'MOODLE_403_STABLE'
database: pgsql
- php: '8.2'
moodle-branch: 'MOODLE_403_STABLE'
database: mariadb
- php: '8.2'
moodle-branch: 'MOODLE_404_STABLE'
database: pgsql
- php: '8.2'
moodle-branch: 'MOODLE_404_STABLE'
database: mariadb
- php: '8.3'
moodle-branch: 'MOODLE_404_STABLE'
database: pgsql
- php: '8.3'
moodle-branch: 'MOODLE_404_STABLE'
database: mariadb

steps:
- name: Check out repository code
Expand Down
5 changes: 5 additions & 0 deletions .stylelintrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
{
"rules": {
"selector-type-no-unknown": [ true, { ignoreTypes: ["/^ion-/"] } ]
}
}
8 changes: 8 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
# Changelog

## 1.0.9 - 2024-05-03
### Changed
- Change "Save" for "Update" when the user has already voted.
- Make the cards stand out more from the background.
- Change behaviour so once the student has voted, they are taken automatically to the results screen.
### Added
- CI tests for Moodle 4.4.

## 1.0.8 - 2024-01-30
### Changed
- Instructions removed when the user can't vote.
Expand Down
2 changes: 1 addition & 1 deletion amd/build/sortvoting.min.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion amd/build/sortvoting.min.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions amd/src/sortvoting.js
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ const saveVote = function(saveSortVoteElement) {
} else {
toastAdd(getString('voteerror', 'mod_sortvoting'), {type: 'danger'});
}
if (result.seeresultsupdated) {
// Reload the whole page so the results tab is visible now but wasn't before (or viceversa).
window.location.reload();
if (result.canseeresults) {
// If the user can see the results, redirect to the results page. Otherwise, reload the page.
window.location.href = result.redirecturl;
} else if (result.allowupdate) {
saveSortVoteElement.removeAttribute('disabled');
} else {
Expand Down
Loading
Loading