Support for initial healthcheck dynamic record #53
Conversation
| @@ -594,6 +708,7 @@ def _apply_update(self, change): | |||
| self.log.info("updating: %s", change) | |||
| new = change.new | |||
| data = getattr(self, f"_params_for_{new._type}")(new) | |||
| self.log.debug("updating: %s", str(data)) | |||
There was a problem hiding this comment.
This looks like a test/debugging log message rather than something targeted at/useful for end users. Intentionally left in?
There was a problem hiding this comment.
Yes. It's a debugging log. It was helpful during the dev but can be safely removed.
I can have a look and test against my GCore account. |
Co-authored-by: Ross McFarland <[email protected]>
Co-authored-by: Ross McFarland <[email protected]>
|
@istr did you get a chance to 👁️ this one? Looks like there's at least a couple minor things left to address from my original feedback. |
* add _GcoreDynamicRecord * Move Gcore specific to healthcheck subkey
|
As requested, I moved the gcore specific healthcheck parameters to a subkey. |
Hi,
Here's my first contribution to OctoDNS.
We use health check dynamic monitoring with Gcore DNS.
The support is quite minimal and managed in parallel of original geodns dynamic record.
Test coverage is 100% done.