ZoneFileSource.list_zones #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzguy
approved these changes
Sep 8, 2023
|
I am not aware of a method to get a list of zones via AFXR or anything either unfortunately. |
|
Hi there, it seems that the ZoneFileSource.list_zones does not check that the zone names ends with a dot properly. When using dynamic zones with octodns_bind.ZoneFileSource, we get a "Invalid zone name foo.tld, missing ending dot" further. In our case, we don't have the final dot in the file names, so use file_extension: "", which is not working with your current implementation of list_zones. It would be better to remove the defined file_extension entirely and then adding a dot in all case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements list_zones for ZoneFileSource.
Unfortunately there doesn't seem to be a way to remotely get a list of zones from a running bind server (via AXFR like queries) so no such support for AxfrSource.
/cc octodns/octodns#1026