Ajout de documentations (README, ...) & Changement de port #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 15, 2020
…IBUTING.md, DEPLOY.md
…in verification...
ArnoHolo
force-pushed
the
update-readme
branch
from
b654700
to
86be419
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.envetconfig/database.yml.Cette PR ajoute plusieurs fichiers de documentation : README, INSTALLATION (comment installer), CONTRIBUTING (comment contribuer / développer), DEPLOY (comment mettre en staging / production).
Elle change aussi le port de l'application : le port 3000 est aussi utilisé par l'application moss-front et entraîne des chargements en boucle en local. L'API est désormais sur le port 3001 pour éviter les conflits (à vérifier dans son fichier
.env! et à mettre à jour le.envcôté front aussi !).Enfin, cette PR met à jour le GoogleOauthCallbackController pour se loguer avec http://localhost:3001/auth/google_oauth2 (sans le front, sans préciser un paramètre "redirect_to")