Skip to content

Commit

Permalink
correct some misstakes
Browse files Browse the repository at this point in the history
  • Loading branch information
OCTO-FRAH committed Sep 4, 2020
1 parent 3b5443f commit 41fa7f0
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 14 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,7 @@ When error occurs, any FA2 contract entry point MUST fail with one of the follow

## Your mission

<!-- prettier-ignore -->We are working on a fungible/multi-asset token compliant with the FA2 standard. We want you to complete the existing implementation of token. The *Total\_supply* entry point is not yet implemented , please finish the job !
<!-- prettier-ignore -->We are working on a fungible/multi-asset token compliant with the FA2 standard. We want you to complete the existing implementation of our token. The *Total\_supply* entry point is not yet implemented , please finish the job !

<!-- prettier-ignore -->1 - Modify the *get\_total\_supply* lambda function in order to retrieve the *total\_supply* information related to the given *token\_id* list.

Expand Down
10 changes: 5 additions & 5 deletions src/frontend/src/pages/Chapters/Camel/ChapterFA20Hook/course.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ Instead of implementing FA2 as a monolithic contract, a permission policy can be

![](/images/small-fa2-hook.png)

Although this approach introduces gas consumption overhead (compared to an all-in-one contract) by requiring an extra inter-contract call, it also offers some other advantages:
Although this approach introduces gas consumption overhead (compared to an all-in-one contract) by requiring an extra inter-contract call, it also offers some other benefits:

1. FA2 core implementation can be verified once, and certain properties (not related to permission policy) remain unchanged.
2. Modification of the permission policy of an existing contract can be done by replacing a transfer hook only. No storage migration of the FA2 ledger is required.
1. The FA2 core implementation can be verified once, and certain properties (not related to permission policy) remain unchanged.
2. The modification of the permission policy of an existing contract can be done by replacing a transfer hook only. No storage migration of the FA2 ledger is required.
3. Transfer hooks could be used for purposes beyond permissioning, such as implementing _custom logic_ for a particular token application

The transfer hook pattern permits to model different transfer permission policies like whitelists, operator lists, etc.
Expand Down Expand Up @@ -60,7 +60,7 @@ In addition to the hook standard, the FA2 standard provides helper functions to

##### Register FA2 core with Hook permission contract

Some helpers functions has been gatthered in a hook library which help defining hooks when implementing a FA2 contract. This library contains following functions and type alias :
Some helpers functions has been gathered in a hook library which help defining hooks when implementing a FA2 contract. This library contains following functions and type aliases :

<!-- prettier-ignore -->The type *fa2\_registry* is a set of address.

Expand All @@ -74,7 +74,7 @@ Some helpers functions has been gatthered in a hook library which help defining
<!-- prettier-ignore -->- the contract interface of entry point "%tokens\_transferred\_hook"
<!-- prettier-ignore -->- a _permission descriptor_

<!-- prettier-ignore -->The function *validate\_hook\_call* ensures that an address in registered in the registry (set of address).
<!-- prettier-ignore -->The function *validate\_hook\_call* ensures that an address is registered in the registry (set of address).

##### Transfer Hooks

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -195,7 +195,7 @@ When error occurs, any FA2 contract entry point MUST fail with one of the follow

## Your mission

<!-- prettier-ignore -->We are working on a fungible token compliant with the FA2 standard. We want you to complete the existing implementation of token. The *Balance\_Of* entry point is not yet implemented , please finish the job !
<!-- prettier-ignore -->We are working on a fungible token compliant with the FA2 standard. We want you to complete the existing implementation of our token. The *Balance\_Of* entry point is not yet implemented , please finish the job !

<!-- prettier-ignore -->The function *retreive\_balance* is responsible for processing each request and providing a response to each request.As you can see, a request is of type *balance\_of\_request*

Expand Down
10 changes: 5 additions & 5 deletions src/frontend/src/pages/Chapters/Pascal/ChapterFA20Hook/course.md
Original file line number Diff line number Diff line change
Expand Up @@ -24,10 +24,10 @@ Instead of implementing FA2 as a monolithic contract, a permission policy can be

![](/images/small-fa2-hook.png)

Although this approach introduces gas consumption overhead (compared to an all-in-one contract) by requiring an extra inter-contract call, it also offers some other advantages:
Although this approach introduces gas consumption overhead (compared to an all-in-one contract) by requiring an extra inter-contract call, it also offers some other benefits:

1. FA2 core implementation can be verified once, and certain properties (not related to permission policy) remain unchanged.
2. Modification of the permission policy of an existing contract can be done by replacing a transfer hook only. No storage migration of the FA2 ledger is required.
1. The FA2 core implementation can be verified once, and certain properties (not related to permission policy) remain unchanged.
2. The modification of the permission policy of an existing contract can be done by replacing a transfer hook only. No storage migration of the FA2 ledger is required.
3. Transfer hooks could be used for purposes beyond permissioning, such as implementing _custom logic_ for a particular token application

The transfer hook pattern permits to model different transfer permission policies like whitelists, operator lists, etc.
Expand Down Expand Up @@ -61,7 +61,7 @@ In addition to the hook standard, the FA2 standard provides helper functions to

##### Register FA2 core with Hook permission contract

Some helper functions has been gathered in a hook library which help defining hooks when implementing a FA2 contract. This library contains following functions and type alias :
Some helper functions has been gathered in a hook library which help defining hooks when implementing a FA2 contract. This library contains following functions and type aliases :

<!-- prettier-ignore -->The type *fa2\_registry* is a _set_ of _address_.

Expand All @@ -75,7 +75,7 @@ Some helper functions has been gathered in a hook library which help defining ho
<!-- prettier-ignore -->* the contract interface of entry point "%tokens\_transferred\_hook"
<!-- prettier-ignore -->* a _permission descriptor_

<!-- prettier-ignore -->the function *validate\_hook\_call* ensures that an address in registered in the registry (set of address).
<!-- prettier-ignore -->the function *validate\_hook\_call* ensures that an address is registered in the registry (set of address).

##### Transfer Hooks

Expand Down
4 changes: 2 additions & 2 deletions src/frontend/src/pages/Chapters/Reason/ChapterFA20/course.md
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ type transferParameter = list(transferMichelson);

### Metadata

The metadata section deals with token definition which specifies the name, and asset caracteristics such as the range od ids (for non-fungible tokens) or total supply of assets (for fungible tokens).
The metadata section deals with token definition which specifies the name, and asset caracteristics such as the range of ids (for non-fungible tokens) or the total supply of assets (for fungible tokens).

<!-- prettier-ignore -->FA2 token contracts MUST implement the *token\_metadata* entry point which get the metadata for multiple token types.

Expand Down Expand Up @@ -252,7 +252,7 @@ When error occurs, any FA2 contract entry point MUST fail with one of the follow

## Your mission

<!-- prettier-ignore -->We are working on a fungible token compliant with the FA2 standard. We want you to complete the existing implementation of token. The *Balance\_Of* entry point is not yet implemented, please finish the job !
<!-- prettier-ignore -->We are working on a fungible token compliant with the FA2 standard. We want you to complete the existing implementation of our token. The *Balance\_Of* entry point is not yet implemented, please finish the job !

<!-- prettier-ignore -->The function *balanceOfRequestsIterator* is responsible for processing each request and providing a response to each request.As you can see, a request is of type *balanceOfRequestMichelson*

Expand Down

0 comments on commit 41fa7f0

Please sign in to comment.