New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve table width calculation #37

Merged

mdonnalley merged 2 commits into main from mdonnalley/table-width

Oct 30, 2024

Contributor

mdonnalley commented Oct 30, 2024

We were double counting the padding when calculating the table width. This prevented the table from taking up the entire width of the terminal
Reduce column width down to 3 + padding * 2 if reducing down to header.length + padding * 2 doesn't reduce the table enough to fit in the terminal


          fix: improve table width calculation

4a71378

mdonnalley added the bug label

git2gus bot commented Oct 30, 2024

This issue has been linked to a new work item: W-17103023


          test: update max width tests

df4da2f

WillieRuemmele approved these changes

View reviewed changes

mdonnalley merged commit 27d2b20 into main

11 checks passed

mdonnalley deleted the mdonnalley/table-width branch

October 30, 2024 20:36

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug