Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: migrate to ESM #538

Merged
merged 7 commits into from
Oct 30, 2023
Merged

feat!: migrate to ESM #538

merged 7 commits into from
Oct 30, 2023

Conversation

mdonnalley
Copy link
Contributor

@mdonnalley mdonnalley commented Oct 23, 2023

BREAKING CHANGES: ESM and node 18 minimum

Closes #540

BREAKING CHANGES: ESM and node 18 minimum
@git2gus
Copy link

git2gus bot commented Oct 23, 2023

This issue has been linked to a new work item: W-14349278

// skip hidden flags
if (f.hidden) continue

const flagSummary = this.sanitizeSummary(f.summary || f.description)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

f.summary ?? f.description

@iowillhoit
Copy link
Contributor

iowillhoit commented Oct 27, 2023

QA NOTES

ESM CLI

npm install @salesforce/[email protected]
or sf update qa

  • 🟢 sf autocomplete prints correct instructions
  • 🟢 Executing instructions enables autocomplete
  • 🟢 Autocompletes commands
  • 🟢 Multiple matches print all options
  • 🟢 Hitting tab cycles through options (on zsh)
  • 🟢 Hitting sf org <tab> prints all org options
  • 🟢 Single match completes whole command
  • 🟢 Flags autocomplete as expected
  • 🟢 Autocompletes for uninstalled JIT plugins (dev)
  • 🟢 Switch to bash with chsh -s /bin/bash and everything looks great

CJS CLI

npm install @salesforce/[email protected]
or sf update cjs

  • 🟢 sf autocomplete prints correct instructions
  • 🟢 Executing instructions enables autocomplete
  • 🟢 Autocompletes commands
  • 🟢 Multiple matches print all options
  • 🟢 Hitting tab cycles through options (on zsh)
  • 🟢 Hitting sf org <tab> prints all org options
  • 🟢 Single match completes whole command
  • 🟢 Flags autocomplete as expected
  • 🟢 Autocompletes for uninstalled JIT plugins (dev)
  • 🟢 Switch to bash with chsh -s /bin/bash and everything looks great

UNRELATED

  • 🟡 I don't think the eval is necessary in th zsh/bash instructions. The sf autocomplete script zsh is just returning a string that needs to be written to the rc file. We source the rc file after the printf to make it ready for immediate use.

@iowillhoit
Copy link
Contributor

@cristiand391 tested with Powershell and it looked good! Just the comment about the eval and this is good to merge @mdonnalley

@mdonnalley mdonnalley mentioned this pull request Oct 30, 2023
@mdonnalley mdonnalley merged commit bf20d15 into main Oct 30, 2023
6 checks passed
@mdonnalley mdonnalley deleted the mdonnalley/esm branch October 30, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update @oclif/core
3 participants