Adds ircbot command to ping staff in lab #95
Conversation
|
I am not sure this could work, for two reasons:
|
|
we did turn this off for |
Eh...IMO sometimes it's useful, if an issue does require attention from someone physically present in the lab... |
|
call it 'weewooweewoo' :P |
|
Pinging with As for the "invasiveness", I don't see how this can be considered invasive at all. It's pinging people by a public mention of their nick in a public irc channel. Any user can achieve the same exact thing by typing out a name. If being contacted through this is a serious concern for a user, there's always the option of blocking mentions from |
| staff_nicks = staff_nicks | {nick for nick in channel_users if nick.startswith(staff_username)} | ||
| nicks_string = ', '.join(sorted(staff_nicks)) | ||
|
|
||
| msg.respond(msg.text.replace("@labstaff", nicks_string)) |
There was a problem hiding this comment.
why not just send the nicks_string instead of returning the replacement?
There was a problem hiding this comment.
My reasoning was that so people being pinged could see the actual message that the ping was for in the notification itself, eg. phone users could see it without having to actually open it up. However, its true that it does bloat things a bit.
Adds a command to ping all staff in the lab.
Currently bound to
@labstaff, which will trigger Create to repeat the message, with your name at the front, and a list of labstaff's nicks where you wrote@labstaff. An example can be seen below.Suggest any formatting changes here.
Note that this does not currently do a proper slack ping. Normally when a user in irc types out a
xxx-slackusername, its converted to a@xxxon Slack, but that doesn't seem to happen when this command is used to make the bot type it. I'm not entirely sure why that happens.