Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1422: PdrDashboard v0.3 costs, tooltips and final improvements (#1435) #1437

Merged
merged 12 commits into from
Jul 30, 2024
Merged

Fix #1422: PdrDashboard v0.3 costs, tooltips and final improvements (#1435) #1437

merged 12 commits into from
Jul 30, 2024

Conversation

KatunaNorbert
Copy link
Member

@KatunaNorbert KatunaNorbert commented Jul 23, 2024 •
edited
Loading

Fixes #1422

@KatunaNorbert
Fix #1433: Rename figures y axis and updated accuracy plot range (#1435)
ec306f5 
* renamed figures y axis and updated accuracy plot range
@KatunaNorbert KatunaNorbert changed the title Fix #1433: PdrDashboard v0.3 costs, tooltips and final improvements (#1435) Fix #1422: PdrDashboard v0.3 costs, tooltips and final improvements (#1435) Jul 23, 2024
kdetry and others added 10 commits July 23, 2024 17:14
@kdetry @KatunaNorbert
Fix #1441: Display number of rows for each table (#1442)
342d50b 
* issue-1441: the row count has been added

* UI updates

---------

Co-authored-by: Norbert <[email protected]>
@calina-c
[Fix #1439] Show selected lines first in predictoor dashboard (#1443)
6c1bd49 
* Remove some callbacks and ensure selected first.
@calina-c
Fix issue with feed searching when predictoors selected. (#1449)
b026cc5
@calina-c
[Fix #1453] Predictoor table columns to match later renditions (#1454)
a052707 
* Fix column descriptions.
* Fix resolution issue with Selenium tests
* Remove toggle columns button added automatically by Dash.
@kdetry
Fix #1434: Show the confidence interval on the Accuracy plot (#1440)
95c80fa 
* issue-1434: Confidence Interval

* issue-1434: Add flag for the confint calculation

* Add objects to allow easier mgmt for previous tuples
@kdetry
issue-1462: The x axis is not order bug (#1463)
481d887
@kdetry
issue-1464: tooltips (#1465)
7ff531f
@calina-c
Merge branch 'main' into issue-1422-PdrDashboard-v03
dee5b46
@KatunaNorbert @calina-c
Fix #1438: Calculate and display tx fee costs (#1444)
b1998a5 
* calculate tx cost

* display costs chart and rename current costs as stakes

* calculate and display total tx costs

* display fees as bars for each predictoor feed comb

* handle case when prices can't be retrieved

* use binance us endpoint to retrieve token prices

* write test for calculating gas fee cost

* test prices are set inside app setup

* enable use of default tick format trough args to fix costs plot

* add tooltip message for costs and more tooltip improvements

---------

Co-authored-by: Calina Cenan <[email protected]>
@KatunaNorbert
use fallback api for fetching token prices
df3bca7
@KatunaNorbert KatunaNorbert marked this pull request as ready for review July 29, 2024 12:37
@KatunaNorbert KatunaNorbert requested review from calina-c and kdetry July 29, 2024 12:37
@KatunaNorbert KatunaNorbert merged commit 19d5ed4 into main Jul 30, 2024
5 checks passed
@KatunaNorbert KatunaNorbert deleted the issue-1422-PdrDashboard-v03 branch July 30, 2024 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calina-c calina-c calina-c approved these changes

@kdetry kdetry Awaiting requested review from kdetry

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[PdrDashboard] v0.3: costs, tooltips and final improvements
3 participants
@KatunaNorbert @calina-c @kdetry