Fix #1384: Improve Predictoors Table #1398

kdetry · 2024-07-15T12:23:53Z

Changes on this PR:

the total_profit, total_acc, avg_stake columns have been added.
the sorting logic has been added
the user column is shortened

calina-c · 2024-07-16T04:34:59Z

@kdetry @KatunaNorbert @idiom-bytes @trentmc
Looking at this PR and working with the predictoor dashboard (and honestly using my personal banking app) recently have given me an idea. At most times, people will only be interested in some specific accounts and it's difficult for them to manage the addresses of those accounts. I propose we add an aliasing table, where users can locally "name" their accounts in a user-friendly way or maybe mark them as favourites (and show them on top of the list). We can possibly do some sort of "favourite" mark for feeds, as well.

Improvements I see:

easier to filter and manage. The user can set the name for "0xabc1234..." as "Alice", "0xefgh5678..." as "Bob" and filter by those values. We can even toggle smth like:
- only showing the favourites
- showing the favourites on top
- showing everything
  obviously the first case would ease a lot of mental load for the user and database load for the app itself
maybe autoselection based on favourites?
this goes for feeds too, if we let the user mark some feeds of interest and show them on top/exclusively

For us it is an extra JOIN, but for the user it might be a huge time-saver since they don't have to paste in filters all the time.

Let me know what you guys think. Maybe it's a bad idea, maybe it's not doable now, but I'd like to discuss it and have an issue if it looks useful to you.

trentmc · 2024-07-16T07:36:56Z

people will only be interested in some specific accounts and it's difficult for them to manage the addresses of those accounts. I propose we add an aliasing table, where users can locally "name" their accounts in a user-friendly way

Gm @calina-c , you're absolutely right, people mostly want to see their accounts, or compare their accounts to global.

And in fact, @KatunaNorbert and I were talking about it yesterday:)

And, we discussed a simple way to do it: specify via ppss.yaml.

My specific suggestion: have a new section in predictoor_ss called "my_addresses" where you can optionally list your addresses. That's it.

Then this can get picked up by Predictoor Dashboard or anywhere else.

We know how to deal with address format already, see eg web3_pp section.
I'm recommending to put it into predictoor_ss, versus more general, because we may want to specify different addresses for other contexts (eg traders). One step at a time.

Appendix: The Predictoor Dashboard prototype slides had this feature too:

KatunaNorbert · 2024-07-16T07:53:20Z

And in fact, @KatunaNorbert and I were talking about it yesterday:)

I like it when multiple people have the same idea, this means it's something of a high value.

We can prioritise it, add it to v0.2 and start working on it right away. Looks like we have a clear description on how to implement it:

specify addresses inside ppss.yaml
make addresses and corresponding feeds selected inside the table when the app starts
nice to have: add a button so app resets to your predictoors when clicking on a button ex: 'My Predictoors'

trentmc · 2024-07-16T07:55:07Z

Looks like we have a clear description on how to implement it:
specify addresses inside ppss.yaml

Yes, and specifically, put it inside the predictoor_ss section. Because it's really for people running predictoors. This also allows us to leverage all the predictoor_ss infra.

KatunaNorbert · 2024-07-16T08:10:29Z

Created the issue:
#1402

kdetry · 2024-07-16T13:46:32Z

I found it inconvenient to fetch all payouts and calculate the table stats with Python because of reloading a huge data on memory. Instead, I implemented an SQL logic to improve performance and reduce performance costs.

https://github.com/oceanprotocol/pdr-backend/pull/1398/files#diff-0e2d99ab25f98454e058b613399431ead8e2af3aa527ba7a6b6ddeca7af610ceR57

KatunaNorbert · 2024-07-17T07:00:04Z

pdr_backend/analytics/predictoor_dashboard/test/test_util.py

+
+    result = get_user_payouts_stats_from_db(ppss.lake_ss.lake_dir)
+
+    print("result--->", result)


remove print or use logger if needed

KatunaNorbert · 2024-07-17T07:08:08Z

pdr_backend/analytics/predictoor_dashboard/dash_components/callbacks.py

@@ -142,13 +145,49 @@ def update_predictoors_table_on_search(
                predictoors_data, "user", search_value, selected_predictoors
            )

+        if user_payout_stats:
+            # Her bir data elemanı için, eşleşen user_payout_stat bulunur ve güncellenir.
+            # Eşleşme yoksa, orijinal data elemanı korunur.


I think we should translate this to english 😄

Sorry my fault :D

KatunaNorbert · 2024-07-17T07:14:14Z

pdr_backend/analytics/predictoor_dashboard/dash_components/callbacks.py

+                    "avg_accuracy": round(data["avg_accuracy"], 2),
+                    "avg_stake": round(data["avg_stake"], 2),
+                    "user": data["user"],
+                }


can we save this values directly on the predictoor_data state inside get_input_data_from_db so we don't have to filter and select them on each predictoor table action?

KatunaNorbert · 2024-07-17T07:21:45Z

pdr_backend/analytics/predictoor_dashboard/dash_components/util.py

+            GROUP BY 
+                "user" 
+        """,
+    )


good job with the query, the data comes in very fast!
I'm wondering if we can unite this query with the get predictoors one and have a get predictoors data query containing all the data we need, should be straight forward.

KatunaNorbert · 2024-07-17T07:23:12Z

Could you also make make the column containing the tables wider? It should be wide enough to have all the columns visible

KatunaNorbert · 2024-07-17T11:40:19Z

pdr_backend/analytics/predictoor_dashboard/dash_components/util.py

+
+
+@enforce_types
+def process_user_payout_stats(


Looks much cleaner now, but we should add a better name to this function: "get_predictoors_data_from_payouts" or something similar

KatunaNorbert · 2024-07-17T11:45:54Z

The accuracy and avg stake on the predictoor row doesn't mach the values from the metrics. I have all the feeds selected for the predictoor so they should mach:

kdetry · 2024-07-17T12:21:48Z

The accuracy and avg stake on the predictoor row doesn't mach the values from the metrics. I have all the feeds selected for the predictoor so they should mach:

for predictor, feed in product(predictoors, feeds):
        # only filter for this particular predictoor and feed pair
        # in order to properly group the data
        filtered_payouts = [
            p for p in payouts if predictor in p["ID"] and feed.contract in p["ID"]
        ]

        slots, accuracies, profits, stakes = process_payouts(filtered_payouts)

        if not slots:
            continue

        avg_stake = ((stakes[-1] + avg_stake) / 2) if avg_stake else stakes[-1]
        total_profit = (profits[-1] + total_profit) if total_profit else profits[-1]
        avg_accuracy = (
            ((accuracies[-1] + avg_accuracy) / 2) if avg_accuracy else accuracies[-1]
        )

In the code block above, you averaged the accuracy value calculated for each pair and predictor. In my example, I calculate the average of all payouts of the predictor.

KatunaNorbert · 2024-07-17T12:34:06Z

I see, so it should be fixed in the metrics calculation then

KatunaNorbert

LGTM! Thanks for also fixing the metrics issue

* Fix #1376: Change callbacks to not store payout data (#1378) * Fix #1375: Add Buttons and Sorting (#1379) * Fix #1373: Separate some concerns in pdr-dashboard. (#1390) * Fix #1374: Display metrics over multiple feeds and predictoors (#1377) * Fix #1400: Fix selections in feed and predictoor list (#1401) * Fix #1385: Add switch to display selected predictoors feeds only (#1395) * Fix #1402: Allow address config for predictoor dashboard. (#1403) * Fix #1404: Allow date period selection (#1405) * Fix #1384: Improve predictoors table by adding accuracy, stake and profit (#1398) * Fix #1409: Add predictoor and feed startup data instead of loading on a dash component (#1411) * Fix #1412: Update dashboard readme with new instructions (#1414) * Fix #1413: Update and split dash_duo tests (#1417)

kdetry added 2 commits July 15, 2024 14:21

issue-1384: part 1

ea92251

issue-1384: part 2

4726743

kdetry added 2 commits July 16, 2024 16:36

issue-1384: Creating the stats data with a new approach

2373150

issue-1384: removed unused util

59d6617

kdetry requested review from KatunaNorbert and calina-c July 16, 2024 13:46

kdetry added 2 commits July 16, 2024 16:58

issue-1384: wrong respose on exception has been fixed

4791c44

issue-1384: conflict fix

147b619

KatunaNorbert reviewed Jul 17, 2024

View reviewed changes

kdetry added 3 commits July 17, 2024 13:46

issue-1384: comment fixes

24a4118

issue-1384: conflict fix

d1f2c7b

issue-1384: conflict fix - 2

55cf9f4

KatunaNorbert reviewed Jul 17, 2024

View reviewed changes

kdetry added 2 commits July 17, 2024 16:05

issue-1384: fix avg_acc and avg_stake calculations

4d9a946

issue-1384: method renaming

04abc7b

KatunaNorbert approved these changes Jul 17, 2024

View reviewed changes

kdetry merged commit 32d2f24 into issue-1357-PdrDashboard-v02 Jul 17, 2024
4 checks passed

kdetry deleted the issue-1384 branch July 17, 2024 14:01

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix #1384: Improve Predictoors Table #1398

Fix #1384: Improve Predictoors Table #1398

kdetry commented Jul 15, 2024 •

edited

Loading

calina-c commented Jul 16, 2024 •

edited

Loading

trentmc commented Jul 16, 2024 •

edited

Loading

KatunaNorbert commented Jul 16, 2024 •

edited

Loading

trentmc commented Jul 16, 2024 •

edited

Loading

KatunaNorbert commented Jul 16, 2024

kdetry commented Jul 16, 2024 •

edited

Loading

KatunaNorbert Jul 17, 2024

KatunaNorbert Jul 17, 2024

kdetry Jul 17, 2024

KatunaNorbert Jul 17, 2024 •

edited

Loading

KatunaNorbert Jul 17, 2024

KatunaNorbert commented Jul 17, 2024

KatunaNorbert Jul 17, 2024

KatunaNorbert commented Jul 17, 2024

kdetry commented Jul 17, 2024

KatunaNorbert commented Jul 17, 2024

KatunaNorbert left a comment


		result = get_user_payouts_stats_from_db(ppss.lake_ss.lake_dir)

		print("result--->", result)

Fix #1384: Improve Predictoors Table #1398

Fix #1384: Improve Predictoors Table #1398

Conversation

kdetry commented Jul 15, 2024 • edited Loading

calina-c commented Jul 16, 2024 • edited Loading

trentmc commented Jul 16, 2024 • edited Loading

KatunaNorbert commented Jul 16, 2024 • edited Loading

trentmc commented Jul 16, 2024 • edited Loading

KatunaNorbert commented Jul 16, 2024

kdetry commented Jul 16, 2024 • edited Loading

KatunaNorbert Jul 17, 2024

Choose a reason for hiding this comment

KatunaNorbert Jul 17, 2024

Choose a reason for hiding this comment

kdetry Jul 17, 2024

Choose a reason for hiding this comment

KatunaNorbert Jul 17, 2024 • edited Loading

Choose a reason for hiding this comment

KatunaNorbert Jul 17, 2024

Choose a reason for hiding this comment

KatunaNorbert commented Jul 17, 2024

KatunaNorbert Jul 17, 2024

Choose a reason for hiding this comment

KatunaNorbert commented Jul 17, 2024

kdetry commented Jul 17, 2024

KatunaNorbert commented Jul 17, 2024

KatunaNorbert left a comment

Choose a reason for hiding this comment

kdetry commented Jul 15, 2024 •

edited

Loading

calina-c commented Jul 16, 2024 •

edited

Loading

trentmc commented Jul 16, 2024 •

edited

Loading

KatunaNorbert commented Jul 16, 2024 •

edited

Loading

trentmc commented Jul 16, 2024 •

edited

Loading

kdetry commented Jul 16, 2024 •

edited

Loading

KatunaNorbert Jul 17, 2024 •

edited

Loading