fix(session): support auto recreate session when upgrade #2959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeachThinking
force-pushed
the
fix/jingtian_support_auto_recreate_session_when_upgrade
branch
from
a8d6bc0
to
cd4840a
Compare
yhilmare
reviewed
Jul 11, 2024
server/odc-service/src/main/java/com/oceanbase/odc/service/session/ConnectSessionService.java
Outdated
Show resolved
Hide resolved
PeachThinking
force-pushed
the
fix/jingtian_support_auto_recreate_session_when_upgrade
branch
from
63d642f
to
d5f4210
Compare
yhilmare
deleted the
fix/jingtian_support_auto_recreate_session_when_upgrade
branch
guowl3
pushed a commit
that referenced
this pull request
Aug 2, 2024
* fix failed to auto recreate session when upgrade * The impact of code changes is limited to multiCloud * response to reivew * response to review * response to review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-bug
What this PR does / why we need it:
When automatically reconnecting in the cloud upgrade scenario, the host is obtained according to
req.getFrom(), so that the created sessionId is consistent with the previously not found sessionIdWhich issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: