enhancement(result-set): only query table constraints when it's necessary #2958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuckyPickleZZ
requested review from
PeachThinking,
yhilmare and
yizhouxw
as code owners
PeachThinking
previously approved these changes
Jul 12, 2024
yizhouxw
reviewed
Jul 17, 2024
server/odc-common/src/main/java/com/oceanbase/odc/common/util/LazyInitObject.java
Outdated
Show resolved
Hide resolved
LuckyPickleZZ
dismissed stale reviews from PeachThinking and yhilmare
via
2c24cc6
PeachThinking
approved these changes
Jul 22, 2024
LioRoger
reviewed
Jul 22, 2024
| * @date: 2024/7/11 | ||
| */ | ||
| public class Lazy<T> { | ||
| private static final Object NO_INIT = new Object(); |
There was a problem hiding this comment.
In my opinion, Lazy may not give accurate meaning of the class intend to do. This class want to provide a delayed function call if needed. It's more like a local cache, if missing then provide a value use provider.
If supplier call returns NO_INIT, get method will be always invoked. Get method seems not a high frequent access function. So move synchronized keyword to method declare, use init flag to control supplier get seems more reasonable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
type-enhancement
What this PR does / why we need it:
When editing result set, ODC would always query constraints. Sometimes this is not necessary. Like only edit rows with
rowid.Which issue(s) this PR fixes:
Fixes #2952
Special notes for your reviewer:
Additional documentation e.g., usage docs, etc.: