Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

security: modify annotations on some service classes #2955

Merged
merged 2 commits into from
Jul 11, 2024
Merged

security: modify annotations on some service classes #2955

merged 2 commits into from
Jul 11, 2024

Conversation

LuckyPickleZZ
Copy link
Collaborator

  1. modify LogicalDatabaseSyncManager from Service to Component
  2. add SkipAuth annotation to DatabaseService#updateObjectSyncStatus

@LuckyPickleZZ LuckyPickleZZ added this to the ODC 4.3.1 milestone Jul 11, 2024
@LuckyPickleZZ LuckyPickleZZ self-assigned this Jul 11, 2024
yhilmare
yhilmare approved these changes Jul 11, 2024
View reviewed changes
Copy link
Contributor

@yhilmare yhilmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yhilmare yhilmare merged commit 579fc8f into dev/4.3.x Jul 11, 2024
7 checks passed
@yhilmare yhilmare deleted the wenmu_431_fix_security_vulnerability branch July 11, 2024 11:24
@LuckyPickleZZ LuckyPickleZZ restored the wenmu_431_fix_security_vulnerability branch July 24, 2024 09:01
@LuckyPickleZZ LuckyPickleZZ deleted the wenmu_431_fix_security_vulnerability branch July 24, 2024 09:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yhilmare yhilmare yhilmare approved these changes

@yizhouxw yizhouxw Awaiting requested review from yizhouxw yizhouxw is a code owner

Assignees

@LuckyPickleZZ LuckyPickleZZ

Labels
None yet
Projects
ODC
Status: Developed
Milestone
ODC 4.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@LuckyPickleZZ @yhilmare