Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(design): ConfigProvider hideOnSinglePage change to false by default #388

Merged
merged 1 commit into from
Dec 28, 2023

Conversation

dengfuping
Copy link
Collaborator

📦 Modified package

  • @oceanbase/design
  • @oceanbase/ui
  • @oceanbase/icons
  • @oceanbase/charts
  • @oceanbase/util
  • @oceanbase/codemod
  • Other (about what?)

🤔 This is a ...

  • New feature
  • Bug fix
  • Site / documentation update
  • Demo update
  • Component style update
  • TypeScript definition update
  • Bundle size optimization
  • Performance optimization
  • Enhancement feature
  • Internationalization
  • Refactoring
  • Code style optimization
  • Test Case
  • Branch merge
  • Workflow
  • Other (about what?)

🔗 Related issue link

💡 Background and solution

  • 统一去掉分页器会有以下问题
    • 批量操作场景,批量操作栏位于分页器左侧,此时只有一页数据但也不应该去掉分页器。
    • 切换 pageSize 如果达到一页数据,则 pageSize 切换器会被隐藏,无法再切换回去。

📝 Changelog

Language Changelog
🇺🇸 English -
🇨🇳 Chinese 🐞 ConfigProvider hideOnSinglePage 默认值改为 false,交由业务侧按需设置,避免统一去掉分页器带来的问题。

☑️ Self-Check before Merge

⚠️ Please check all items below before requesting a reviewing. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • TypeScript definition is updated/provided or not needed
  • Tests is updated/provided or not needed
  • Changelog is provided or not needed

@dengfuping dengfuping merged commit bb61585 into master Dec 28, 2023
4 of 6 checks passed
Copy link

github-actions bot commented Dec 28, 2023

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant