Delay the creation of the context used when a package failed to build up until the package failed #6278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… up until the package failed
kit-ty-kate
force-pushed
the
delay-context-creation
branch
from
33d9210 to
c0bcb68
Compare
rjbou
reviewed
Jan 15, 2025
There was a problem hiding this comment.
The PR contains 2 things: the delay of context creation for package build, and the delay of metadata processes as the sumary is not always printed. PR title is good, but main comment and master changes should contains both. Ideally, 2 commits if it can be easily split.
Otherwise, lgtm!
| @@ -606,7 +612,7 @@ let set_verbose_f, print_verbose_f, isset_verbose_f, stop_verbose_f = | |||
| (* implem relies on sigalrm, not implemented on win32. | |||
| This will fall back to buffered output. *) | |||
| if Sys.win32 then () else | |||
| let files = OpamStd.List.sort_nodup compare files in | |||
| let files = OpamStd.List.sort_nodup OpamStd.Compare.compare files in | |||
There was a problem hiding this comment.
Suggested change
| let files = OpamStd.List.sort_nodup OpamStd.Compare.compare files in | |
| let files = OpamStd.List.sort_nodup String.compare files in |
?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed while reviewing #6274.
It turns out that we try to fetch the revision of each packages being built even before executing the command, but that information is only used in rare cases so if many git packages are used this can cause some wasted time (not too much, up to a couple seconds on slow hardware with large installs, but not nothing)