Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change example of non-letter in version ordering #6252

Merged

Conversation

gridbugs
Copy link
Contributor

The "Package Formulas" grammar in the manual says that valid characters for version numbers are <identchar> | "+" | "." | "~". Notably this does not include the "#" character. This change updates the example of a comparing a letter to a non-letter character to use a non-letter character that may appear in a version number.

Please update master_changes.md file with your changes.

@gridbugs gridbugs force-pushed the clarify-version-ordering-comparison-example branch from 1eaf91e to 1ed6527 Compare October 18, 2024 05:43
@rjbou rjbou force-pushed the clarify-version-ordering-comparison-example branch from 1ed6527 to 5efcc15 Compare October 21, 2024 11:02
Copy link
Collaborator

@rjbou rjbou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I've added a commit to remove a redundancy that I spotted while reviewing (+ defined twice for version).
I propose to not merge it now, to queue it on #5349. rebased

@rjbou rjbou added AREA: DOCUMENTATION PR: QUEUED Pending pull request, waiting for other work to be merged or closed STATE: READY TO MERGE labels Oct 21, 2024
gridbugs and others added 2 commits October 21, 2024 17:43
The "Package Formulas" grammar in the manual says that valid characters
for version numbers are `<identchar> | "+" | "." | "~"`. Notably this
does not include the "#" character. This change updates the example of a
comparing a letter to a non-letter character to use a non-letter
character that may appear in a version number.

Signed-off-by: Stephen Sherratt <[email protected]>
@rjbou rjbou force-pushed the clarify-version-ordering-comparison-example branch from 5efcc15 to a3c6ec9 Compare October 21, 2024 15:44
@rjbou rjbou removed the PR: QUEUED Pending pull request, waiting for other work to be merged or closed label Oct 21, 2024
@kit-ty-kate
Copy link
Member

Thanks!

@kit-ty-kate kit-ty-kate merged commit 1e9b9be into ocaml:master Oct 21, 2024
2 checks passed
@kit-ty-kate kit-ty-kate added this to the 2.4.0~alpha1 milestone Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants