Fix incorrect error message in configure #5667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
related #5661 |
rjbou
approved these changes
Sep 14, 2023
kit-ty-kate
reviewed
Sep 14, 2023
configure.ac
Outdated
| @@ -202,8 +202,10 @@ AS_IF([ test ${WIN32} -eq 1 ],[ | |||
| AS_IF([ test "x${CC64}" = "x" ], [ | |||
| AS_IF([ test "$ARCH" = "i386" ], | |||
| [T_CC64=x86_64-w64-mingw32-gcc | |||
| COMP_ARCH='x64' | |||
There was a problem hiding this comment.
maybe
Suggested change
| COMP_ARCH='x64' | |
| COMP_ARCH='x86_64' |
given that’s how it is named by cygwin
There was a problem hiding this comment.
It's a confusing one - Microsoft call it x64 (cf. the other side of the AS_IF!). However, I think you're right and I've changed it - if we're building 32-bit mingw, then we call it x86_64 in the display (as you say, because Cygwin and GCC do!); if we're building 32-bit MSVC, then we call it x64 (because Microsoft does) and then the complaint always matches the name of the missing compiler! 🤯
Somewhat confusingly, the architecture referred to the compiler which had definitely just been found.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
opam requires both a 32-bit and a 64-bit C compiler when compiling for 64-bit Windows. However, for mingw-w64, the error message confusingly displayed the architecture of the compiler which was installed.