Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the sandbox scripts in absence of the OPAMROOT variable #5662

Merged
merged 1 commit into from
Sep 11, 2023
Merged

Fix the sandbox scripts in absence of the OPAMROOT variable #5662

merged 1 commit into from
Sep 11, 2023

Conversation

kit-ty-kate
Copy link
Member

@kit-ty-kate kit-ty-kate commented Sep 11, 2023 •
edited
Loading

Bug I introduced by error in #5634

/home/kit_ty_kate/.opam/opam-init/hooks/sandbox.sh contains local modification, overwrite ? [y/n] y
[ERROR] Sandboxing is not working on your platform archarm:
        "~/.opam/opam-init/hooks/sandbox.sh build sh -c echo SUCCESS | tee check-write" exited with code 1 "/home/kit_ty_kate/.opam/opam-init/hooks/sandbox.sh: line 105: OPAMROOT: unbound variable"

@kit-ty-kate kit-ty-kate added this to the 2.2.0~alpha3 milestone Sep 11, 2023
@kit-ty-kate
Copy link
Member Author

Merged without waiting for CI to finish to avoid breaking users of the master branch. We'll look into adding a test for the sandbox with an absent OPAMROOT variable in a subsequent PR soon.

@kit-ty-kate kit-ty-kate merged commit 7f949f3 into ocaml:master Sep 11, 2023
26 checks passed
@kit-ty-kate kit-ty-kate deleted the fix-sandbox branch September 11, 2023 16:15
@kit-ty-kate kit-ty-kate mentioned this pull request Sep 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjbou rjbou rjbou approved these changes

Assignees
No one assigned
Labels
IMPORTANT KIND: BUG
Projects
None yet
Milestone
2.2.0~alpha3
Development

Successfully merging this pull request may close these issues.
2 participants
@kit-ty-kate @rjbou