reftests: add test for operators in opamfile filters #5642
Conversation
rjbou
force-pushed
the
test-filter-operators
branch
from
4fc119c
to
8462183
Compare
rjbou
force-pushed
the
test-filter-operators
branch
from
8462183
to
6d32dc6
Compare
rjbou
force-pushed
the
test-filter-operators
branch
from
dfe6255
to
1798862
Compare
rjbou
force-pushed
the
test-filter-operators
branch
from
1798862
to
364f9c6
Compare
rjbou
force-pushed
the
test-filter-operators
branch
from
364f9c6
to
f50596c
Compare
| - install c 1 [required by gteq] | ||
| - install gteq 1 | ||
| - install ok 1 [required by gteq] | ||
| ### :: Combination :: |
There was a problem hiding this comment.
I think it's definitely good to have some tests for this, but I'm not sure that reftests are the correct harness? Wouldn't it be better to be testing the filter parser then evaluation of filters separately (alcotest-style or some such), rather than invoking the whole of opam machinery to test this?
I'm pretty sure the tests above this comment would definitely be clearer as a standard test case harness and I'm fairly even the tests below would be?
(i.e. I think the reftests framework is excellent for full-blown tests, but these feel more like unit tests and the framework's overkill for that?)
There was a problem hiding this comment.
I think it's fine to have in the reftest since it's something that is usable and most used from the command line tool
kit-ty-kate
force-pushed
the
test-filter-operators
branch
from
f50596c
to
9722749
Compare
|
Thanks! |
No description provided.