-
Notifications
You must be signed in to change notification settings - Fork 365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
opam tree: Allow packages with a specific version, directories or local opam files, as input #5613
Conversation
dbfa1df
to
b284fc1
Compare
b284fc1
to
b5261cd
Compare
thinking about it some more i think we should not support these option as their name are confusing and hits towards an action in opam-tree instead of in the underlying opam-pin action. I would advise for thinking about them again for 2.3. |
I think we should support These command shortcuts, ie have access to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The global idea is great, it would simplify opam tree usage.
I've put some remarks on the code itself, some tiny optimisations, support of rec/subpath & tests.
8b604aa
to
b27a341
Compare
d11d450
to
beddf05
Compare
9dee994
to
777a822
Compare
…al opam files, as input
Co-authored-by: R. Boujbel <[email protected]>
Co-authored-by: R. Boujbel <[email protected]>
Co-authored-by: R. Boujbel <[email protected]>
…ersion of an already installed package Co-authored-by: R. Boujbel <[email protected]>
777a822
to
54f0e9b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good, thanks!
Fixes #5493
Fixes #5287
Additional questions:
--recursive
and--subpath
?--with-version
?my personal opinion for those is to say "we can merge this now, open an issue for those options and leave it for later"
TODO: