Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[new release] bitwuzla-cxx (0.6.0) #26836

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

recoules
Copy link
Contributor

@recoules recoules commented Nov 4, 2024

SMT solver for AUFBVFP (C++ API)

CHANGES:

Update Bitwuzla sources.

Fix a segmentation fault that occurs during the garbage collection of node managers.

Vendor submodules:

CHANGES:

Update [Bitwuzla](https://github.com/bitwuzla/bitwuzla/releases/tag/0.6.0) sources.

Fix a segmentation fault that occurs during the garbage collection of node managers.

Vendor submodules:
- [Bitwuzla](https://github.com/bitwuzla/bitwuzla) tag:0.6.0
@shonfeder
Copy link
Collaborator

Hi! Thanks for publishing this update.

In CI we have the following failures:

arm32-ocaml-4.14
bitwuzla-cxx.0.6.0
tests (failed: The compilation of bitwuzla-cxx.0.6.0 failed at "dune build -p bitwuzla-cxx -j 79 @install @runtest".)
arm32-ocaml-5.2
bitwuzla-cxx.0.6.0
tests (failed: The compilation of bitwuzla-cxx.0.6.0 failed at "dune build -p bitwuzla-cxx -j 79 @install @runtest".)

Do you intend to support these platforms?

@recoules
Copy link
Contributor Author

recoules commented Nov 5, 2024

Hi @shonfeder,

I do not see why there is a bus error on arm32.
I do not know either if previous versions were tested for this architecture too (regression) or if it never worked on it.

Yet, I do not have easy access to this kind of architecture and I will not have time to investigate (for instance, if the issue is related to the bitwuzla original c++ code or only to the binding). Thus, I propose to add an opam filter for arm32.

Best regards,
Frédéric Recoules

PS: seems the previous version had the same issue, and the same filter.

@shonfeder
Copy link
Collaborator

PS: seems the previous version had the same issue, and the same filter.

I see! Perhaps this should be upstreamed to the package data in the source?

Thanks for the fix here! Despite the github UI's report, all CI jobs appear to be passing!

@shonfeder shonfeder merged commit 8582dee into ocaml:master Nov 5, 2024
2 of 3 checks passed
@shonfeder
Copy link
Collaborator

Thanks again for taking the time to share your updates! 🙏

Please consider announcing on changes on discuss.ocaml.org :)

@recoules
Copy link
Contributor Author

recoules commented Nov 5, 2024

Thank you.

Perhaps this should be upstreamed to the package data in the source?

I updated the opam.template file in the source repository.

@shonfeder
Copy link
Collaborator

Excellent. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants