Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable a few packages for OCaml 5.3 #26831

Merged
merged 5 commits into from
Nov 6, 2024
Merged

Commits on Nov 4, 2024

  1. Use OCAMLPARAM to build in OCaml 5.3

    Add `OCAMLPARAM=_,keywords=5.2` to `build-env` which allows these
    packages to build in OCaml 5.3 by disabling the `effect` keyword during
    the build only.
    dra27 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    d061ddf View commit details
    Browse the repository at this point in the history
  2. Add upperbound on re for caisar

    Caisar uses Re__core.replace_string directly, which got caught by a
    refactoring in 1.12.0
    dra27 committed Nov 4, 2024
    Configuration menu
    Copy the full SHA
    70df880 View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Increase lowerbound on dune for caisar-onnx.0.2

    It fails when building with ocaml-protoc-plugin.4.2.0 with 2.9.3:
    
    File "lib/onnx/dune", line 11, characters 11-30:
    11 |   (package ocaml-protoc-plugin))
                    ^^^^^^^^^^^^^^^^^^^
    Error: Package ocaml-protoc-plugin does not exist
    
    Note that all subsequent versions of ocaml-proto-plugin require at least
    Dune 3.2, so the simple lowerbound is sufficient - there's no version of
    dependencies where this package can succesfully build with Dune 2.9.x
    dra27 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    dd70dec View commit details
    Browse the repository at this point in the history
  2. Conflict 5.3.0~alpha1

    dra27 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    5653f50 View commit details
    Browse the repository at this point in the history
  3. Correct lowerbound on base for caisar.0.2

    Uses Option.value_or_thunk which was added in base v0.15.0
    dra27 committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    53af682 View commit details
    Browse the repository at this point in the history