Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package srt.0.3.1 #26808

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Package srt.0.3.1 #26808

wants to merge 4 commits into from

Conversation

toots
Copy link
Contributor

@toots toots commented Oct 29, 2024

srt.0.3.1

Binding for the Secure, Reliable, Transport protocol library
Secure Reliable Transport (SRT) is an open source transport technology
that optimizes streaming performance across unpredictable networks, such
as the Internet.
This package provides OCaml bindings to the C implementation library.



🐫 Pull-request generated by opam-publish v2.3.0

@shonfeder
Copy link
Collaborator

Quite a few CI failures on different compiler versions. I'll mark this as needing reporter action.

@toots
Copy link
Contributor Author

toots commented Oct 29, 2024

Quite a few CI failures on different compiler versions. I'll mark this as needing reporter action.

Woo thanks, this needs review indeed.

@mseri
Copy link
Member

mseri commented Nov 3, 2024

Many revdeps are breaking. Should we add an upper bound on the broken version of liquidsoap?

# File "io/srt_io.ml", line 510, characters 19-33:
# 510 |       let events = Srt.Poll.uwait t.p ~max_fds ~timeout:conf_timeout#get in
#                          ^^^^^^^^^^^^^^
# Error: This function has type
#          Srt.Poll.t -> timeout:int -> Srt.Poll.event list
#        It is applied to too many arguments; maybe you forgot a `;'.
# make[1]: *** [Makefile:395: io/srt_io.cmx] Error 2
# make[1]: Leaving directory '/home/opam/.opam/4.14/.opam-switch/build/liquidsoap.2.1.3/src'
# make: *** [Makefile:10: all] Error 2

(this can be done in a separate PR before merging this one)

@toots
Copy link
Contributor Author

toots commented Nov 4, 2024

Many revdeps are breaking. Should we add an upper bound on the broken version of liquidsoap?

# File "io/srt_io.ml", line 510, characters 19-33:
# 510 |       let events = Srt.Poll.uwait t.p ~max_fds ~timeout:conf_timeout#get in
#                          ^^^^^^^^^^^^^^
# Error: This function has type
#          Srt.Poll.t -> timeout:int -> Srt.Poll.event list
#        It is applied to too many arguments; maybe you forgot a `;'.
# make[1]: *** [Makefile:395: io/srt_io.cmx] Error 2
# make[1]: Leaving directory '/home/opam/.opam/4.14/.opam-switch/build/liquidsoap.2.1.3/src'
# make: *** [Makefile:10: all] Error 2

(this can be done in a separate PR before merging this one)

This looks like a regression in the CI. These package already have an upper bound (most likely from one of the previous srt releases): https://opam.ocaml.org/packages/liquidsoap/liquidsoap.2.0.0/

@mseri
Copy link
Member

mseri commented Nov 4, 2024

Not really, here it says that it conflicts with srt < 0.1.2: https://github.com/ocaml/opam-repository/blob/master/packages/liquidsoap/liquidsoap.2.0.0/opam#L128

This means that any version >= 0.1.2 is good. We need to add a new conflict to srt >= 0.3.1

@toots
Copy link
Contributor Author

toots commented Nov 4, 2024

Not really, here it says that it conflicts with srt < 0.1.2: https://github.com/ocaml/opam-repository/blob/master/packages/liquidsoap/liquidsoap.2.0.0/opam#L128

This means that any version >= 0.1.2 is good. We need to add a new conflict to srt >= 0.3.1

Woof my bad! That's what happens when you respond too early.. Just pushed the changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants