[new release] ppxlib.0.33.0

[NathanReb]

Release of ppxlib.0.33.0.

Changes

• Fix a bug where Code_path.main_module_name would not properly remove extensions from the filename and therefore return an invalid module name.
  (Fix extension removal bug in Code_path.main_module_name ocaml-ppx/ppxlib#512, @NathanReb)

• Add -unused-type-warnings flag to the driver to allow users to disable only the generation of warning 34 silencing structure items when using [@@deriving ...] on type declarations.
  (Add an -unused-type-warnings flag to the driver (bis) ocaml-ppx/ppxlib#511, @mbarbin, @NathanReb)

• Make -unused-code-warnings flag to the driver also controls the generation of warning 34 silencing structure items when using [@@deriving ...] on type declarations.
  (Make -unused-code-warnings also controls warning 34 suppression items ocaml-ppx/ppxlib#510, @mbarbin, @NathanReb)

• Driver: Add -unused-code-warnings=force command-line flag argument.
  (Add driver flag to force opting in to unused code warnings in derived code ocaml-ppx/ppxlib#490, @mbarbin)

• new functions Ast_builder.{e,p}list_tail that take an extra tail expression/pattern argument parameter compared to Ast_builder.{e,p}list, so they can build ASTs like a :: b :: c instead of only [ a; b ].
  (make Ast_builder.{e,p}list able to build lists such as a :: b :: c ocaml-ppx/ppxlib#498, Rename and modify e/plist_v2 to e/plist_tail ocaml-ppx/ppxlib#502, @v-gb, @NathanReb)

• Fix Longident.parse so it also handles indexing operators such as .!(), .%(;..)<-, or Vec.(.%())
  (Context_free.special_function: fix the parsing of indexing operators ocaml-ppx/ppxlib#494, @Octachron)

• Add a special_function' variant which directly takes a Longident.t argument to avoid the issue that Longident.t cover distinct syntaxic classes which cannot be easily parsed by a common parser
  (Context_free: add a special_function' variant ocaml-ppx/ppxlib#496, @Octachron).

• Keep location ranges consistent when migrating Pexp_function nodes from 5.2+ to older versions
  (Fix issue 503 ocaml-ppx/ppxlib#504, @jchavarri)

• Fix -locations-check behaviour so it is no longer required to pass -check as well to enable location checks.
  (Fix -locations-check behaviour ocaml-ppx/ppxlib#506, @NathanReb)

[NathanReb]

Thanks @mbarbin for finding out about the malformed opam file. I kind of created the PR and left it there because the CI takes a while to run and didn't check that it actually started running.

[NathanReb]

I went through the 5.2 revdeps failures and couldn't find anything that seemed ppxlib related. I'll wait for the 4.14 revdeps failures before undrafting anyway, just in case some packages aren't compatible with 5.2 yet.

CC @mseri or any other opam-repo maintainers, do you spot anything unusual in the revdeps failures here?

[NathanReb]

It seems there's quite a few revdeps build that weren't over when I reviewed the first time, I'll take some time to look at those and the non overlapping 4.14 ones.

[mseri]

I don't see regressions, but most jobs are failing with solver timeouts, so who knows... :(

I have already opened an issue on the ocaml infrastructure repository about the timeouts, they are not limited to this PR. So we should not consider this a blocker for this PR.

[NathanReb]

I think I went through most, if not all meaningful build failures on 5.2 and couldn't find errors related to this release so I will proceed with undrafting.

I have a feeling that the number of false positives on opam-ci is growing with each release and it's becoming increasingly hard to review the revdeps failures. Are you aware of any plan to improve it? I'd be happy to help with this as it's reaching a critical point for ppxlib releases.

[NathanReb]

Ah, just missed your message, thanks for your help on this!

[mseri]

Here is the issue: ocaml/infrastructure#147
Indeed, the timeouts are growing but the CI team is looking into it

[NathanReb]

This should be good to go, let me know if anything's blocking!

[shonfeder]

Hi, @NathanReb 👋 :)

Do you think this test failure on ppx_rapper may be related to this update?

#=== ERROR while compiling ppx_rapper_async.3.0.0 =============================#
# context              2.3.0~alpha~dev | linux/x86_64 | ocaml-base-compiler.4.14.2 | file:///home/opam/opam-repository
# path                 ~/.opam/4.14/.opam-switch/build/ppx_rapper_async.3.0.0
# command              ~/.opam/opam-init/hooks/sandbox.sh build dune build -p ppx_rapper_async -j 255 @install @runtest
# exit-code            1
# env-file             ~/.opam/log/ppx_rapper_async-7-47e779.env
# output-file          ~/.opam/log/ppx_rapper_async-7-47e779.out
### output ###
# File "test/ppx/test.expected.ml", line 1, characters 0-0:
# /usr/bin/git --no-pager diff --no-index --color=always -u _build/default/test/ppx/test.expected.ml _build/default/test/ppx/test.actual.ml
# diff --git a/_build/default/test/ppx/test.expected.ml b/_build/default/test/ppx/test.actual.ml
# index b4f5634..42d05ce 100644
# --- a/_build/default/test/ppx/test.expected.ml
# +++ b/_build/default/test/ppx/test.actual.ml
# @@ -220,7 +220,8 @@ let list =
#                       [@ocaml.warning "-33"]) item pack) Dynparam.empty elems in
#            let query =
#              (let open Caqti_request in find_opt) ~oneshot:true
# -              (let open Caqti_type in tup2 bool packed_list_type)
# +              ((let open Caqti_type in tup2 bool packed_list_type)
# +              [@ocaml.warning "-33"])
#                ((let open Caqti_type in
#                    tup2 int (tup2 string (tup2 bool (option string))))
#                [@ocaml.warning "-33"]) sql in
# @@ -257,8 +258,8 @@ let collect_list =
#                       [@ocaml.warning "-33"]) item pack) Dynparam.empty elems in
#            let query =
#              (let open Caqti_request in collect) ~oneshot:true
# -              packed_list_type ((let open Caqti_type in string)
# -              [@ocaml.warning "-33"]) sql in
# +              ((packed_list_type)[@ocaml.warning "-33"])
# +              ((let open Caqti_type in string)[@ocaml.warning "-33"]) sql in
#            Db.collect_list query versions in
#    wrapped
#  module Suit : Ppx_rapper_runtime.CUSTOM =

[mseri]

No, that is quite an old failure. I think this is good to merge