Octez 17.2 packages #24134
Merged
Octez 17.2 packages #24134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
macOS tests are failing: |
also needs a 5.0 constraint |
|
Rather than an ocaml5 constraint, normally we do to be compatible with both versions. |
|
https://gitlab.com/tezos/tezos/-/merge_requests/9576 an MR to fix this |
killian-delarue
force-pushed
the
octez-17.2
branch
from
a623d34
to
5b21bfd
Compare
The use of version 17.1 should be prevented. Octez v17.2 is a security fix. The packages for Otcerz v15.0 was marked as unavailable when Octez v15.1 security upgrade was released. |
|
The opam repository is not intended to be a dumping ground for thousands of unavailable packages, which is what all these Octez packages are turning into. @raphael-proust @killian-delarue might we have a discussion about merging the Octez packages into <10 for future releases? As far as I can tell, there is no real interdependency from other packages on the Octez ones, so they might as well be submitted as a single package |
|
If this is a security fix, then this is presumably quite urgent. What's happening with the Mac build failure reported above? And @raphael-proust, don't we need to constrain this release to OCaml <5 while your upstream fix is applied? |
In this PR we are only marking a version that we want to prevent being used. Yes, the next versions will contain less opam packages. |
The fix will be applied for the next release, I have added a constraint here for this version |
Specifically, we have https://gitlab.com/tezos/tezos/-/merge_requests/8637 upstream which should land soon and reduce the number of packages in further releases. It should reduce the number of package by 38 if I counted correctly. Further reductions are planned afterwards too. |
|
There are quite a lot of failures due to the number of packages being tested and the size taken by the builds filling out the available disk space of the machines, but it looks good overall and does not affect any non-tezos packages so let's merge this and fix things later if there are actual issues. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Octez v17.2 packages.