-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package lens.1.2.5: Migration to ppxlib #18575
Conversation
packages/lens/lens.1.2.5/opam
Outdated
"ppx_deriving" {< "5.0"} | ||
"ppx_tools" {build} | ||
"ppxfind" {build} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is still the case? It seems to conflict with your changelog
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Of course you are right, I forgot to update the opam file. I'm going to submit again. @kit-ty-kate
@pdonadeo could you return the fix in the opam upstream? I'm not sure |
Also, I'm gonna put my ppx_deriving maintainer hat on for a second: the ppx_deriving API is deprecated and if you have time to switch it would be better to use |
Good to go now. Thanks! |
Thanks to you @kit-ty-kate for your job 😃 |
No description provided.