Draft: Move to upstream signature-help #1375
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The diff in the testsuite shows that the documentation if not fetch as it should be. We should either have Merlin fetch the doc itself or return the position of the function identifier, I will have a look. |
voodoos
reviewed
Sep 20, 2024
rgrinberg
reviewed
Sep 20, 2024
|
@xvw could you please add the |
xvw
approved these changes
Sep 24, 2024
xvw
changed the title
rgrinberg
approved these changes
Sep 24, 2024
|
Closing as part of #1383 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @voodoos @xvw