Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to ppx_expect v0.17.0 #1306

Merged
merged 3 commits into from
Sep 29, 2024
Merged

Move to ppx_expect v0.17.0 #1306

merged 3 commits into from
Sep 29, 2024

Conversation

voodoos
Copy link
Collaborator

@voodoos voodoos commented Jun 11, 2024

No description provided.

Copy link
Member

@rgrinberg rgrinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll update nix in a later PR

@voodoos
Copy link
Collaborator Author

voodoos commented Jun 11, 2024

Actually ppx_expect.0.17.0 requires at least OCaml 5.1.

We can either disable testing on 4.14 or wait until we merge 5.2 support.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 4550

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 131 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.09%) to 21.935%

Files with Coverage Reduction New Missed Lines %
ocaml-lsp-server/src/ocaml_lsp_server.ml 131 36.54%
Totals Coverage Status
Change from base Build 4536: 0.09%
Covered Lines: 5589
Relevant Lines: 25480

💛 - Coveralls

@rgrinberg rgrinberg merged commit b87266a into ocaml:master Sep 29, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants