[503] Use source information in uids to jump to the correct file and provide occurrences in both the interface and the implementation #1857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoos
force-pushed
the
503-distinct-uids
branch
from
9b0730d to
618267f
Compare
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
Nov 4, 2024
…implementation files
That way if the cmt files are outdated we don't return non-sensical results.
voodoos
force-pushed
the
503-distinct-uids
branch
from
2b3cb50 to
25a4e0f
Compare
voodoos
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In OCaml 5.3's cmts the uids contain information indicating there origin (an implementation or an interface). In this PR we use that information to jump to interface files when needed.
This is sensible to the freshness of the cmt file for the current module. An heuristic based on identifiers is used to alleviate the risk of Merlin giving wrong answers when the cmts are out-of-date. If this proves insufficient we can make it stricter by checking the creation time of the artifacts.