Occurrences canonicalization bugfix #1855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voodoos
approved these changes
Oct 8, 2024
xvw
approved these changes
Oct 8, 2024
voodoos
reviewed
Oct 8, 2024
liam923
force-pushed
the
occurrences-canonicalization-bugfix
branch
from
92bf06a to
74db4a3
Compare
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Nov 26, 2024
CHANGES:
Tue Nov 26 17:30:42 CET 2024
+ merlin binary
- Respect the `EXCLUDE_QUERY_DIR` configuration directive when looking for cmt
files (ocaml/merlin#1854)
- Fix occurrences bug in which relative paths in index files are resolved against the
PWD rather than the SOURCE_ROOT (ocaml/merlin#1855)
- Fix exception in polarity search (ocaml/merlin#1858 fixes ocaml/merlin#1113)
- Fix jump to `fun` targets not working (ocaml/merlin#1863, fixes ocaml/merlin#1862)
- Fix type-enclosing results instability. This reverts some overly
aggressive deduplication that should be done on the client side. (ocaml/merlin#1864)
- Fix occurrences not working when the definition comes from a hidden source
file (ocaml/merlin#1865)
voodoos
added a commit
to voodoos/opam-repository
that referenced
this pull request
Nov 26, 2024
CHANGES:
Tue Nov 26 17:30:42 CET 2024
+ merlin binary
- Respect the `EXCLUDE_QUERY_DIR` configuration directive when looking for cmt
files (ocaml/merlin#1854)
- Fix occurrences bug in which relative paths in index files are resolved against the
PWD rather than the SOURCE_ROOT (ocaml/merlin#1855)
- Fix exception in polarity search (ocaml/merlin#1858 fixes ocaml/merlin#1113)
- Fix jump to `fun` targets not working (ocaml/merlin#1863, fixes ocaml/merlin#1862)
- Fix type-enclosing results instability. This reverts some overly
aggressive deduplication that should be done on the client side. (ocaml/merlin#1864)
- Fix occurrences not working when the definition comes from a hidden source
file (ocaml/merlin#1865)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves a bug where relative paths in an index are resolve against the
PWDinstead of based on theSOURCE_ROOTdirective. See the first commit for a test case demonstrating the issue. I may have introduced this bug in #1840, or it may have predated that PR - I'm not sure.