destruct: some refactoring
#1747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it easier to process expressions (such as pattern parrent) and, when processing function parameters, allows it to be used as a fallback if `destruct` doesn't act on a parameter (but on the function body).
Simplification of the `destruct node` function by moving the case of destruct in the presence of an expression in a dedicated function.
Simplification of the `destruct node` function by moving the case of destruct in the presence of a record in a dedicated function.
Simplification of the `destruct node` function by moving the case of destruct in the presence of a pattern in a dedicated function.
|
Fixed on the last commit! Thanks for the review. |
xvw
force-pushed
the
some-destruct-refactoring
branch
from
4a77f67 to
e6e3966
Compare
voodoos
added a commit
to voodoos/merlin
that referenced
this pull request
May 13, 2024
from xvw/some-destruct-refactoring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch pull to
masterthe refactoring introduced in voodoos#10, taking into account field-puning processing (and other updates not introduced in preview 5.2.0). The test suite is still running, and each refactoring is in an isolated commit to facilitate integration with other branches.