-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support relocation kind 0003 and extend IMAGE_REL_ types #141
Open
jonahbeckford
wants to merge
1
commit into
ocaml:master
Choose a base branch
from
jonahbeckford:relocation-kind-0003
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+28
−1
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just for my own understanding:
add32(off, s)
, so thatoff
in LLVM corresponds toptr->addr
in Flexlink ands
in LLVM corresponds tos
in Flexlink.IMAGE_REL_AMD64_ADDR64
in LLVM (RELOC_ABS
in Flexlink) is implemented byadd64(off, s + imageBase)
, so thats + imageBase
in LLVM corresponds tos
in Flexlink.Do you understand why the
s
arguments do not seem to match between the two cases?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Going one step further, those equations imply that
imageBase = 0
.I spent a lot of time looking and I couldn't find out why IMAGE_REL_AMD64_ADDR64 seems to work. The math for all the other relocation kinds make sense.
However, two things ...
/base:
base addresslink.exe
option is fixed for OCaml executable to be0x10000
atflexdll/cmdline.ml
Line 47 in 80496b5
and also the same in
flexdll/create_dll.ml
Line 77 in 80496b5
for OCaml plugins / stubs.
flexdll/reloc.ml
Lines 470 to 475 in 80496b5
into absolute relocations by
Reloc.abs
:flexdll/coff.ml
Lines 437 to 444 in 80496b5
So my suspicion was that the
Reloc.abs
absolute relocations were being translated at CreateProcess time byntdll.LdrInitializeThunk
(or whatever is reading the PE.reloc
section) to complete theimageBase
adjustment.@dra27, any chance you can explain why
base_addr
(orimage_base
for DLLs) is not used in the calculations?(These calculations are undocumented in flexdll and fairly complicated)