-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add x-maintenance-intent to dune opam files #11275
base: main
Are you sure you want to change the base?
Conversation
The OPAM files are generated automatically from |
98c9a89
to
c1a0148
Compare
c1a0148
to
c1c53bc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of these changes need to be discussed because while we do release them as packages I don't think all of them are meant to be used by others.
e.g. I don't think that we would do a patch-release for a bug in stdune
if it doesn't affect the dune
package. We'd probably fix it upstream to prevent it becoming an issue in the future but a lot of these packages are really just to support Dune.
002b084
to
4a5b03b
Compare
@rgrinberg Can you take a look and confirm that this matches our maintenance policy? |
Signed-off-by: ArthurW <[email protected]> Signed-off-by: Etienne Marais <[email protected]>
Signed-off-by: Etienne Marais <[email protected]>
4a5b03b
to
4b63540
Compare
I encounter an issue while working on this PR. To be able to have the maintenance field in Also, it seems that the |
With regards to the switch test, the issue seems to be that the packages are getting pinned to 3.17.1 instead of 3.18:
But I do agree that this PR probably needs to be split into two, one that bumps to 3.17 and adds the formatting and one that bumps to 3.18 and updates the maintenance intent. |
You are right, let's do it this way 👍 |
Using #11274 to add it to every opam files. My understanding is that only the
"(latest)"
version is the one actively maintained, but it's easy to change if you want to include more versions.