test: Repro 'dune fmt' crash in presence of Nix result

A 'ocamlformat' executable is added to the test to avoid depending on OCamlformat. Signed-off-by: Jules Aguillon <[email protected]>
ocaml · Dec 16, 2024 · be4fc2b · be4fc2b
1 parent 3fc17ee
commit be4fc2b
Show file tree

Hide file tree

Showing 5 changed files with 21 additions and 0 deletions.
diff --git a/test/blackbox-tests/test-cases/read-only-symlink-target.t/.ocamlformat b/test/blackbox-tests/test-cases/read-only-symlink-target.t/.ocamlformat
diff --git a/test/blackbox-tests/test-cases/read-only-symlink-target.t/dune b/test/blackbox-tests/test-cases/read-only-symlink-target.t/dune
@@ -0,0 +1,2 @@
+(executable
+ (name ocamlformat))
diff --git a/test/blackbox-tests/test-cases/read-only-symlink-target.t/dune-project b/test/blackbox-tests/test-cases/read-only-symlink-target.t/dune-project
@@ -0,0 +1 @@
+(lang dune 2.8)
diff --git a/test/blackbox-tests/test-cases/read-only-symlink-target.t/ocamlformat.ml b/test/blackbox-tests/test-cases/read-only-symlink-target.t/ocamlformat.ml
@@ -0,0 +1,2 @@
+(* Avoid adding dependencies to this cram test *)
+let () = print_endline "(* formatted *)"
diff --git a/test/blackbox-tests/test-cases/read-only-symlink-target.t/run.t b/test/blackbox-tests/test-cases/read-only-symlink-target.t/run.t
@@ -0,0 +1,16 @@
+Nix can leave a symlink to a store path in the tree, often called 'result'.
+'dune fmt' crashes because of that.
+
+  $ RESULT=`mktemp -d`
+  $ echo "let x  = 2" > "$RESULT/foo.ml"
+  $ chmod -R a-w "$RESULT"
+  $ ln -s "$RESULT" result
+
+This command should succeed:
+
+  $ dune fmt 2>/dev/null
+  [1]
+
+Allow Dune to remove temporary files (calling Dune crashes without this):
+
+  $ chmod -R u+w "$RESULT"
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		(* Avoid adding dependencies to this cram test *)
		let () = print_endline "(* formatted *)"