Add an -unused-type-warnings flag to the driver #493
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
NathanReb
force-pushed
the
disable-deriving-warn-34-silencing
branch
from
c5ad841
to
e06ff1f
Compare
|
CC @mbarbin, if you want to test this feature. CC @ceastlund, I'd be curious to know if you get any warnings when enabling this flag for JS' codebase. |
This was referenced May 30, 2024
|
I created a preview package that includes this change, and tested it in a PR in a project that could benefits from that. I was able to remove my hack and coverage stayed at 100%. 👍 |
This allows disabling the generation of `let _ = fun (_ : t) -> ()` strucutre items for each type using derivers. The feature was meant to automatically disable warning 34 when using `[@@deriving ...]` Signed-off-by: Nathan Rebours <[email protected]>
NathanReb
force-pushed
the
disable-deriving-warn-34-silencing
branch
from
e06ff1f
to
c5ed5c6
Compare
mbarbin
added a commit
to mbarbin/ppxlib
that referenced
this pull request
Jul 15, 2024
This allows disabling the generation of `let _ = fun (_ : t) -> ()` strucutre items for each type using derivers. The feature was meant to automatically disable warning 34 when using `[@@deriving ...]` This is inspired by ocaml-ppx#493 but adapted for ocaml-ppx#510. Signed-off-by: Mathieu Barbin <[email protected]>
patricoferris
approved these changes
Jul 16, 2024
| -------------------------------------------------------------------------------- | ||
|
|
||
| Whenever a set of types has a [@@deriving ...] attached, ppxlib's driver always | ||
| generate structure items meant to disable unused type warnings (warning 34) for |
There was a problem hiding this comment.
Suggested change
| generate structure items meant to disable unused type warnings (warning 34) for | |
| generates structure items meant to disable unused type warnings (warning 34) for |
| We can see that the driver generated two `let _ = fun (_ : ...`, one for each type | ||
| in the set. | ||
|
|
||
| We have a flag that disable this behaviour and allows unused type warnings to be |
There was a problem hiding this comment.
Suggested change
| We have a flag that disable this behaviour and allows unused type warnings to be | |
| We have a flag that disables this behaviour and allows unused type warnings to be |
|
|
||
| We have a flag that disable this behaviour and allows unused type warnings to be | ||
| reported properly. Passing that flag to the driver should remove the two previously | ||
| mentionned items. |
There was a problem hiding this comment.
Suggested change
| mentionned items. | |
| mentioned items. |
There was a problem hiding this comment.
@patricoferris I will verify how much of the original code I re-used and apply your review comments to the other branch as well. Thanks!
|
@patricoferris We were discussing with @NathanReb and I've made an attempt to implement this feature on top of another PR, see #511 . I am not sure which matches best what Nathan had in mind, just giving you the heads up. |
|
Yes this PR is a bit out of date now. Since @mbarbin started working on the right implem, I'd prefer to take his contributions! Let's close this! |
mbarbin
added a commit
to mbarbin/ppxlib
that referenced
this pull request
Jul 16, 2024
This allows disabling the generation of `let _ = fun (_ : t) -> ()` strucutre items for each type using derivers. The feature was meant to automatically disable warning 34 when using `[@@deriving ...]` This is inspired by ocaml-ppx#493 but adapted for ocaml-ppx#510. Signed-off-by: Mathieu Barbin <[email protected]>
mbarbin
added a commit
to mbarbin/ppxlib
that referenced
this pull request
Jul 16, 2024
This allows disabling the generation of `let _ = fun (_ : t) -> ()` strucutre items for each type using derivers. The feature was meant to automatically disable warning 34 when using `[@@deriving ...]` This is inspired by ocaml-ppx#493 but adapted for ocaml-ppx#510. Signed-off-by: Mathieu Barbin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows disabling the generation of
let _ = fun (_ : t) -> ()strucutre items for each type using derivers.The feature was meant to automatically disable warning 34 when using
[@@deriving ...].This is based on top of #492 to ease testing for the feature, only the last commit is relevant.