-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proper README. #1
Conversation
This looks basically good to me. The README explains what things can go wrong with a backoff, which is a good thing to mention, and it mentions that backoff can reduce contention. It might be useful to slightly expand on how contention forms (i.e. quadratic amount of shared memory traffic caused by cache invalidations) and how backoff reduces such contention, which is by forming a kind of "queue" such that not all retry at the same time (kind of like an application of probabilistic sleep sort) so that people not already familiar with backoffs could also understand when it makes sense to use a randomized exponential backoff. |
For contention is this enough ?
Or should I do something more details ? (In this case, should I (and can I) directly take your paragraph in your kcas bloc post ? (I am also working on a paragraph about the |
That paragraphs looks good to me. You could then continue by explaining that with the exponential backoff the CPUs will then not all attempt to perform the CAS at the same leading to reduction in the amount of bus traffic. |
Should we also include e.g. |
Yes, I am going to set it up. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added a couple of minor nits and there is the comment about explaining contention and how backoff helps with that, but this looks good, so I'll mark this as approved. Feel free to merge once you feel done. We can always fine tune things later.
Also, would be great to get a release out soon on opam, so we can then remove the backoff from Kcas and Saturn and use this library!
I will finish that tomorrow morning 👍 Thanks. |
Speaking of using this library, I already created a draft PR to Kcas to use backoff from this library, during which I noticed that OCaml 4 is not supported. |
26814ac
to
0af2a1e
Compare
No description provided.