Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure git to work on windows in ci #12

Conversation

Alizter
Copy link
Contributor

@Alizter Alizter commented Aug 22, 2023

No description provided.

@Alizter
Copy link
Contributor Author

Alizter commented Aug 22, 2023

Hmm I guess it wasn't the carriage returns...

@Alizter Alizter closed this Aug 22, 2023
@Alizter Alizter reopened this Aug 22, 2023
@Alizter Alizter force-pushed the ps/branch/chore__configure_git_to_work_on_windows_in_ci branch from 04d6600 to f0c90c5 Compare August 22, 2023 20:43
@Alizter
Copy link
Contributor Author

Alizter commented Aug 22, 2023

Trying again: before we did the git line return stuff after the checkout. This time before.

@Alizter
Copy link
Contributor Author

Alizter commented Aug 22, 2023

Here is the issue for future disgruntled CI maintainers: janestreet/ppx_expect#40

@Alizter
Copy link
Contributor Author

Alizter commented Aug 22, 2023

@rgrinberg Windows CI is now working, please merge.

@rgrinberg rgrinberg merged commit 892e7ec into ocaml-dune:master Aug 22, 2023
4 of 7 checks passed
@Alizter Alizter deleted the ps/branch/chore__configure_git_to_work_on_windows_in_ci branch August 22, 2023 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants