Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!: Django 4 #2379

Merged
merged 15 commits into from
Nov 8, 2024
Merged

feat!: Django 4 #2379

merged 15 commits into from
Nov 8, 2024

Conversation

faucomte97
Copy link
Contributor

@faucomte97 faucomte97 commented Nov 5, 2024

Upgrade from Django 3.2 to Django 4.2

  • Upgraded all Django-related libraries, and reorganise where they sit, i.e., move the ones also installed by Rapid Router to the common package
  • Updated our custom security middleware to continue setting the X-XSS-Protection header to 1 as Django stopped doing it
  • Renamed the captcha library to django-recaptcha
  • Updated all URLs to use re_path instead of url
  • Extended Django's UserAdmin class to be able to still add custom Django admin panel actions to it
  • Updated the two_factor templates that we overrode a while back to customise them, to match the new latest version of the library
  • Updated the two_factor views that we overrode a while back to customise them, to match the new latest version of the library
  • Targeted Django admin panel's logout button using the form action instead of the href of the anchor which got updated to a button by Django
  • Replaced force_text with force_bytes
  • Replaced ugettext with gettext

This change is Reviewable

@faucomte97 faucomte97 self-assigned this Nov 5, 2024
@faucomte97 faucomte97 marked this pull request as ready for review November 6, 2024 17:12
@faucomte97 faucomte97 changed the title feat: Django 4 feat!: Django 4 Nov 8, 2024
@faucomte97 faucomte97 merged commit ed0467c into master Nov 8, 2024
4 of 6 checks passed
@faucomte97 faucomte97 linked an issue Nov 13, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SIM-88344
2 participants