fix: Upgrade to Python 3.12 #2344
Conversation
.github/workflows/ci.yml
Outdated
| with: | ||
| node-version: 16.x | ||
| - name: Install dependencies | ||
| run: | | ||
| pip install pipenv | ||
| pipenv install --dev --system | ||
| pip install -U "git+https://github.com/ocadotechnology/rapid-router@python312#egg=rapid-router" |
.github/workflows/snyk.yaml
Outdated
| @@ -26,7 +26,7 @@ jobs: | |||
| - name: Generate requirements | |||
| run: pip freeze > requirements.txt | |||
| - name: Run Snyk to check for vulnerabilities in Python | |||
| uses: snyk/actions/python-3.8@master | |||
| uses: snyk/actions/python-3.10@master | |||
There was a problem hiding this comment.
why have you hardcoded this to 3.10? why not 3.12?
There was a problem hiding this comment.
Reviewable status: 0 of 11 files reviewed, 2 unresolved discussions (waiting on @faucomte97 and @SKairinos)
.github/workflows/ci.yml line 32 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
remember to change
Done.
.github/workflows/snyk.yaml line 29 at r1 (raw file):
Previously, SKairinos (Stefan Kairinos) wrote…
why have you hardcoded this to 3.10? why not 3.12?
Done.
There was a problem hiding this comment.
Reviewed 7 of 11 files at r1, 4 of 4 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @SKairinos)
There was a problem hiding this comment.
Dismissed @SKairinos from 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @faucomte97)
This change is