Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributor frontend 4 #10

Merged
merged 15 commits into from
Sep 17, 2024
Merged

Contributor frontend 4 #10

merged 15 commits into from
Sep 17, 2024

Conversation

SKairinos
Copy link
Contributor

@SKairinos SKairinos commented Sep 13, 2024

This change is Reviewable

@SKairinos SKairinos linked an issue Sep 13, 2024 that may be closed by this pull request
Copy link

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 15 of 15 files at r1, 2 of 2 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @SKairinos)


src/pages/agreementSignatures/SignLatestAgreementForm.tsx line 60 at r2 (raw file):

                  >
                    latest agreement
                  </Link>

It's a bit mouthier but let's say "I have read, understood and agreed to the terms of the latest agreement."

Code quote:

                  I have read and understood the{" "}
                  <Link
                    to={LINK_GH_CONTRIBUTING.replace("{commitId}", agreementId)}
                    target="_blank"
                  >
                    latest agreement
                  </Link>

Copy link

@faucomte97 faucomte97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 3 of 3 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @SKairinos)

@SKairinos SKairinos merged commit 1ae9d5f into development Sep 17, 2024
7 checks passed
@SKairinos SKairinos deleted the contributor-frontend-4 branch September 17, 2024 13:04
@cfl-bot
Copy link
Collaborator

cfl-bot commented Dec 13, 2024

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

agreement signatures page
3 participants