fix: Edit Task modal now retains edits to Cancelled date

[claremacrae]

Types of changes

Changes visible to users:

• Bug fix (prefix: fix - non-breaking change which fixes an issue)

Internal changes:

• Tests (prefix: test - additions and improvements to unit tests and the smoke tests)

Description

When changing status type to CANCELLED, use the Cancelled Date as today instead of the Done Date.

Motivation and Context

Fixes #3089

• Edit Modal ignores edits to cancelled date #3089

How has this been tested?

• running existing tests
  • this actually fixed two of the existing tests, not just the one that linked to the issue being fixed here
• manual exploratory testing

Screenshots (if appropriate)

Checklist

• My code follows the code style of this project and passes yarn run lint.
• My change has adequate Unit Test coverage.

Terms

• My contribution follows this project's contributing guide
• I agree to follow this project's Code of Conduct

[claremacrae]

Hi @ilandikov, if/when you have time, could you review this please?

[ilandikov]

I'm approving with a couple of suggestions =)

[ilandikov]

Feel free to resolve by yourself and merge =)

[ilandikov]

One more thing, should there be a test added to EditableTask.test.ts? At the end of the day, it's that class that changes the behaviour, and EditableTask.applyEdits() is tested, but not with regards to the changes in this PR

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[claremacrae]

One more thing, should there be a test added to EditableTask.test.ts? At the end of the day, it's that class that changes the behaviour, and EditableTask.applyEdits() is tested, but not with regards to the changes in this PR

In an ideal world, probably yes - fair point.

However, I'm comfortable that the changes are covered in tests somewhere though - and feel I've spent enough time on this issue... If it fails again, we will find it.