-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Completing a daily recurring task creates task set to same day [the day before Australian clocks switch to daylight savings] #2309
Comments
Hi @sofie-bird, thanks for using Tasks, and for a very clear bug report. FYI, I've tweaked the formatting of your report, so that the task lines can be copied and pasted in to markdown docs. Can't reproduce the problemI'm really puzzled by this, as I complete tasks like this, on their scheduled date all the time. So I just tried the following steps:
Today's date is 2023-09-30 I get the correct result:
Related issue reportsI've just re-read the following report... It sounds like it might be similar to yours. However, they were never able to reproduce it and we ended up closing it unresolved. What is different about our setup?To summarise:
So, whilst it does look like there is an issue, if I cannot reproduce it, there is nothing I can do to fix it. So all I think of is to try to figure out what, if anything, is different in your new vaults from mine.
British Summer Time
The thing is, the recurring field is recognised, so I don't think this is the problem, as Tasks reads data from right to left, stopping when it reaches unrecognised text. But what happens when you edit the original task? Can you please confirm that you see the same as this: That screenshot confirms that both the emojis and their values were read correctly by Tasks. |
Thanks for the prompt response. I can confirm the task appears correctly (as in your screenshot) in the task editor -- I tested tasks created both manually and using the editor, both had the issue. It is correctly reading the emojis. My timezone is AEST (UTC +10) Edit - having read that original ticket, I note it's the same timezone, and the date of the issue (Oct 1 2022) was the day before we switched into daylight savings. |
Good spot... Since that last ticket was written, (I believe) I now understand how to set timezones in the Tasks automated tests. So assuming that you confirm it's OK tomorrow, then when I have time, I can add some tests to confirm the problem. I've no idea how much work it will be to fix it, so can't promise when a fix might be released... |
I've updated the title of both issues to indicate what you've worked out, @sofie-bird ... thanks. |
I tested this morning and I have found that:
So it seems like the current system time is not a factor, something about calculating the date across the timezone-change when entering daylight savings (eg 3am becomes 4am) is causing the issue. No worries on the timeline of the fix, conveniently I have a plugin right here to set myself a reminder for why some tasks might play up October 5 next year :D |
Hi Sophie, That's brilliant - super helpful. Thanks for your understanding, too... |
Confirm that I have the same problem here. As @sofie-bird said, the current system time doesn't appear to be important. In my case, I set both the due date and scheduled dates, and it is the due date that seems to be important. |
Thanks Brian. Yes, for recurring tasks it’s the Due date that has the highest priority in deciding the next date. |
I am facing a related issue in NZST (daylight time entered on 2024-09-29). Toggling the recurrence rule |
@ishanarora Is it wrong just that one week, or every week? |
@claremacrae it is correct for every week before. Toggling
|
@ishanarora have your clocks just changed - or are they about to change? |
Clocks changed on 2024-09-29 at 2am into 3am |
Workaround for the bug with `moment().local(true)` incorrectly handling the early hours of the DST is entered into.
I believe I have it pinned down. It appears
The bug is propagated to |
Please check that this issue hasn't been reported before.
Expected Behavior
On tasks that repeat every day, completing the task should create a new task with the started / scheduled / due date incremented by 1.
Current behaviour
On tasks that repeat every day, and are scheduled for the current day, completing the task creates a new task with the same started / scheduled / due date.
This only occurs if the scheduled (or due or started) date is set to today (if it's set in the future or the past, expected behaviour occurs). It only occurs when the recurring setting is "every day". ("every 2 days", "every week" etc produce expected behaviour).
I have reproduced this on two separate vaults in Windows and iPad (obsidian 1.4.8) that run different plugins, as well as a brand new vault running only Tasks plugin.
Steps to reproduce
The task is completed and a new task appears above it with the same scheduled date.
Which Operating Systems are you using?
Obsidian Version
1.4.14
Tasks Plugin Version
4.8.1
Checks
Possible solution
No response
The text was updated successfully, but these errors were encountered: