Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recurring Task 'every day' gets stuck at the end of a month [the day before Australian clocks switch to daylight savings] #1200

Closed
2 of 6 tasks
Quejinok opened this issue Oct 1, 2022 · 9 comments
Labels
scope: recurrence Anything to do with recurring/repeating tasks type: bug Something isn't working type: no action needed Conclusion of the discussion was that no changes to Tasks are required

Comments

@Quejinok
Copy link

Quejinok commented Oct 1, 2022

Expected Behavior

On completion of a recurring daily task task should be marked as completed and a new task created for the next day. Recurrence term used is "every day"

Obsidian installed on Apple Mac Mini (M1 chip) running latest version of Monterey

Current behaviour

Task is completed (and ticked); however, for the first task of a new month (eg. 1st October) the new task is created for the same day as the completed task. Repeated attempts at completing task results in more completed tasks for the current day plus a new incomplete task for the current day.

Steps to reproduce

  1. Create a task that uses the term "every day" in the recurrent task field.
  2. Continue completing the task until the 1st day of a new month - complete this task.
  3. Check completed and incomplete tasks for this entry - there should be at least on completed task for the 1st of the month plus one incomplete for the same day.

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version

0.15.9

Tasks Plugin Version

1.15.0

Checks

  • I have tried it with all other plugins disabled and the error still occurs

Possible solution

Change daily task to seven weekly tasks that recur on every Sunday, every Monday, etc

Note weekly, monthly and other tasks do not seem to be impacted.

@Quejinok Quejinok added the type: bug Something isn't working label Oct 1, 2022
@claremacrae claremacrae added the scope: recurrence Anything to do with recurring/repeating tasks label Oct 1, 2022
@claremacrae claremacrae changed the title Recurring Task - every day Recurring Task 'every day' gets stuck at the end of a month Oct 1, 2022
@claremacrae
Copy link
Collaborator

Thank you for the bug report.

I tried to reproduce it with my understanding of the information supplied, and it worked for me.

- [ ] do stuff 🔁 every day 📅 2023-10-04
- [x] do stuff 🔁 every day 📅 2023-10-03 ✅ 2022-10-01
- [x] do stuff 🔁 every day 📅 2023-10-02 ✅ 2022-10-01
- [x] do stuff 🔁 every day 📅 2023-10-01 ✅ 2022-10-01
- [x] do stuff 🔁 every day 📅 2023-09-30 ✅ 2022-10-01
- [x] do stuff 🔁 every day 📅 2023-09-29 ✅ 2022-10-01
- [x] do stuff 🔁 every day 📅 2023-09-28 ✅ 2022-10-01
- [x] do stuff 🔁 every day 📅 2023-09-27 ✅ 2022-10-01

I thought there was a report similar to this some time ago that couldn't be reproduced, but I can't find it after much searching.

However, if we have enough information, we can try and write a unit test in the source code to reproduce it, so please could you provide as much information as you think of about the situation.

  • Please test it again, and see if you can yourself reproduce the problem still
  • Paste in an example line, that does reproduce the problem (please change the description, though, for privacy)
  • What day and roughly what time did the problem occur
  • What timezone are you in?
  • Had you just updated the Tasks plugin and not restarted
  • Had you used this task before 2022-09-30 - did it recur then?

@claremacrae claremacrae added the question Further information is requested label Oct 1, 2022
@Quejinok
Copy link
Author

Quejinok commented Oct 1, 2022 via email

@claremacrae
Copy link
Collaborator

Wow, thank you @Quejinok for a really helpful reply, and for setting up the test ready for next month.

Based on your description, I do wonder whether it's a time-of-day issue rather than a month one. In case it is a time-of-day issue, you might be able to try reproducing it an other days before then, at different times.

We don't currently have any automated tests that exercise the code in different time zones and different times of day, only on different dates. It might be worth figuring out how to do that - and also for when the clocks change.

I can't promise when I will have time to do that, though. If I haven't been able to do it by the start of next month, your experiments will be really helpful.

@claremacrae
Copy link
Collaborator

I will run up a dummy daily task and keep a log (starting from 20 Oct) then see what happens on 1 November and report back.

HI @Quejinok gentle ping, in the hope that you might have time to keep any eye on this... Thanks in advance!

@Quejinok
Copy link
Author

Quejinok commented Oct 31, 2022 via email

@Quejinok
Copy link
Author

Quejinok commented Nov 2, 2022 via email

@claremacrae claremacrae added type: no action needed Conclusion of the discussion was that no changes to Tasks are required and removed question Further information is requested labels Nov 2, 2022
@claremacrae
Copy link
Collaborator

Hi @Quejinok,

Ah well, thank you very much indeed for trying to reproduce the problem.

@claremacrae
Copy link
Collaborator

As this hasn't been seen again, I'm going to close it for now, as no action is currently required.

@claremacrae claremacrae closed this as not planned Won't fix, can't repro, duplicate, stale Jan 21, 2023
@claremacrae claremacrae changed the title Recurring Task 'every day' gets stuck at the end of a month Recurring Task 'every day' gets stuck at the end of a month [the day before Australian clocks switch to daylight savings] Sep 30, 2023
@claremacrae
Copy link
Collaborator

There has been another report of this, so I've updated the title of this one with what has been learned.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: recurrence Anything to do with recurring/repeating tasks type: bug Something isn't working type: no action needed Conclusion of the discussion was that no changes to Tasks are required
Projects
None yet
Development

No branches or pull requests

2 participants