Edit Modal ignores edits to cancelled date

[ilandikov]

Please check that this issue hasn't been reported before.

• I searched previous Bug Reports didn't find any similar reports.

Expected Behavior

In Edit Modal setting status to cancelled and setting canceled date to any non today's date and clicking Apply button should save the task with the input cancelled date.

Example:

today is 2024-09-01
I set status to cancelled, the cancelled date is 2024-09-01, I set the cancelled date to any other date -> the task is saved with 2024-09-01 as cancelled date

Current behaviour

In Edit Modal setting status to cancelled and canceled date to any non today's date and clicking Apply button saves the task with today's cancelled date.

Example:

today is 2024-09-01
I set status to cancelled, the cancelled date is 2024-09-01, I set the cancelled date to 2022-02-02 -> the task is saved with 2022-02-02 as cancelled date

Steps to reproduce

1. Open Edit Task modal on an existing task - [ ] #task todo (Global filter is set to #task)
2. Set status to Cancelled (THIS IS THE IMPORTANT STEP, IF OMITTED, EVERYTHING WORKS FINE)
3. Set cancelled date to any date than today's date
4. Click Apply

Which Operating Systems are you using?

• Android
• iPhone/iPad
• Linux
• macOS
• Windows

Obsidian Version

1.7.1

Tasks Plugin Version

7.10.0

Checks

• I have tried it with all other plugins disabled and the error still occurs

The cancelled date is enabled in the settings.

Possible solution

No response

[claremacrae]

I don't fully understand.

Does it matter whether the Cancelled date is enabled or disabled in settings?

Does the problem occur in 7.9.0?

I wonder whether this is related to either of these:

• Done/Completion date not getting added to original task when entered through Task modal [as user had turned off the 'add done date' setting #2859
• Allow manually setting done dates through task modal [when the 'add done date' setting is disabled] #2860

[ilandikov]

I was unclear. There can be a relationship, but this is a different bug/behaviour.

I tried to clarify by adding examples in the description. Let me know if it is still unclear.

The cancelled date is enabled in the settings.

[claremacrae]

Thanks.

This is odd:

I asked about 7.9.0 in case I broke the code with the addition of the (disabled) date-picker button...

[ilandikov]

Fixed, thanks.

I will try 7.9.0 and keep you posted.

[claremacrae]

Edit Modal ignores cancel date

It does edit it under some circumstances.

[claremacrae]

... such as if I edit a task that is cancelled, and change the Cancelled date, the edit is preserved.

[ilandikov]

It does edit it under some circumstances.

Right, I found that the thing that exposes the bug is a status change from non-cancelled to cancelled.

[claremacrae]

That would be good to include in the Steps to Reproduce, ideally by giving a markdown line to edit, to avoid ambiguity when testing.

[ilandikov]

Done

[claremacrae]

Steps to reproduce

1. Open Edit Task modal
2. Set status to Cancelled (THIS IS THE IMPORTANT STEP, IF OMITTED, EVERYTHING WORKS FINE)
3. Set cancelled date to any date than today's date
4. Click Apply

I cannot reproduce the problem with following these steps, because Apply is disabled due to the empty description.

I generally request that users provide a Markdown line in a code-block that can be copied-and-pasted in to a markdown file, so we can copy that line, and know that we are always consistently starting the reproduction from the exact same point.

[ilandikov]

My bad, added additional info

[claremacrae]

Perfect. Thanks.

[claremacrae]

This is the code that enables manual edits to the Done date to be preserved by the Edit Task modal, if the user edits the Done date after changing the status:

obsidian-tasks/src/ui/EditableTask.ts

Lines 243 to 248 in 787f8e0

	// Then apply the new status to the updated task, in case a new recurrence
	// needs to be created.
	// If there is a 'done' date, use that for today's date for recurrence calculations.
	// Otherwise, use the current date.
	const today = doneDate ? doneDate : window.moment();
	return updatedTask.handleNewStatusWithRecurrenceInUsersOrder(this.status, today);

Indeed, the workaround for the bug is to set the required Cancelled date in the modal's Done date field.

So the fix is going to be something like:

• If the new status type is DONE, use the Done date for today
• If the new status type is CANCELLED, use the Cancelled date for today