Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit Task modal: creating a task with both Cancelled and Done is possible #2986

Open
2 of 7 tasks
ilandikov opened this issue Jul 24, 2024 · 1 comment
Open
2 of 7 tasks
Labels
scope: edit task The Create or edit task modal/dialog type: bug Something isn't working

Comments

@ilandikov
Copy link
Collaborator

ilandikov commented Jul 24, 2024

Please check that this issue hasn't been reported before.

  • I searched previous Bug Reports didn't find any similar reports.

Expected Behavior

The Modal should not let create a task with both Cancelled and Done dates set - the Apply button should not be accessible

Current behaviour

The Apply button is normal and a task with Cancelled and Done date is created

Steps to reproduce

  • Create a task (- [ ] blabla)
  • Set cursor on the task
  • Open Edit task modal
  • Input valid dates in Done and Cancelled fields
  • Click Apply

Which Operating Systems are you using?

  • Android
  • iPhone/iPad
  • Linux
  • macOS
  • Windows

Obsidian Version

1.6.7

Tasks Plugin Version

7.6.0

Checks

  • I have tried it with all other plugins disabled and the error still occurs

Possible solution

Make the Modal disable the Apply button when both Done and Cancelled date are present.

I have a compact one-line fix for this but, is it testable only manually due to the architecture of our modal. An improvement on that matter can be made, but that is another topic.

@ilandikov ilandikov added type: bug Something isn't working scope: edit task The Create or edit task modal/dialog labels Jul 24, 2024
@ilandikov ilandikov changed the title Edit task modal: creating a task with both Cancelled and Done date should not be possible Edit Task modal: creating a task with both Cancelled and Done is possible Jul 24, 2024
@claremacrae
Copy link
Collaborator

Good spot...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: edit task The Create or edit task modal/dialog type: bug Something isn't working
Projects
None yet
2 participants