Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Edit task modal: it should not be possible to save a task with done and cancelled date #3130

Closed
4 tasks done
ilandikov opened this issue Oct 20, 2024 · 3 comments
Closed
4 tasks done
Labels
scope: edit task The Create or edit task modal/dialog type: enhancement New feature or request

Comments

@ilandikov
Copy link
Collaborator

⚠️ Please check that this feature request hasn't been suggested before.

  • I searched previous Ideas in Discussions didn't find any similar feature requests.
  • I searched previous Issues didn't find any similar feature requests.
  • I am only requesting a single feature. Multiple changes should be split into individual requests, with links between them.
  • I believe my requested feature will be generally applicable to other users, not just me: it is not uniquely tied to my personal workflow.

🔖 Feature description

In the current edit task modal it is possible to set done and cancelled date to the task. I suggest that this kind of task is wrong and this should not happen.

✔️ Solution

Make the Apply button unusable while done and cancelled valid dates are present, highlight done and cancelled date input blocks with red.

❓ Alternatives

Hide/show done and cancelled date based on status:

  • if status is todo, do not show either
  • if status is done, show only done date
  • if status is cancelled, show only cancelled date

📝 Additional Context

No response

@ilandikov ilandikov added the type: enhancement New feature or request label Oct 20, 2024
@ilandikov ilandikov changed the title It should not be possible to save a task with done and cancelled date Edit task modal: it should not be possible to save a task with done and cancelled date Oct 20, 2024
@ilandikov ilandikov added the scope: edit task The Create or edit task modal/dialog label Oct 20, 2024
@claremacrae
Copy link
Collaborator

At first glance this seems like a duplicate of:

@ilandikov
Copy link
Collaborator Author

ilandikov commented Oct 20, 2024

Indeed, I duplicated myself, <facepalm/>

@claremacrae claremacrae closed this as not planned Won't fix, can't repro, duplicate, stale Oct 20, 2024
@claremacrae
Copy link
Collaborator

Hahah. And you even searched the "I searched previous Ideas..." 😉

image

The labels are pretty useful for those searches... (thanks for adding them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: edit task The Create or edit task modal/dialog type: enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants